From: David Miller <davem@davemloft.net>
To: herbert@gondor.hengli.com.au
Cc: netdev@vger.kernel.org
Subject: Re: bridge: Fix fatal typo in setup of multicast_querier_expired
Date: Mon, 30 Apr 2012 13:27:38 -0400 (EDT) [thread overview]
Message-ID: <20120430.132738.647233864900000159.davem@davemloft.net> (raw)
In-Reply-To: <20120430102256.GA32587@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.hengli.com.au>
Date: Mon, 30 Apr 2012 20:22:56 +1000
> Unfortunately it seems that I didn't properly test the case of
> an expired external querier in the recent multicast bridge series.
>
> The setup of the timer in that case is completely broken and leads
> to a NULL-pointer dereference. This patch fixes it.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
...
> - br_multicast_querier_expired, 0);
> + br_multicast_querier_expired, (unsigned long)br);
> setup_timer(&br->multicast_query_timer, br_multicast_query_expired,
> (unsigned long)br);
> }
>
> Sorry for the screw-up.
Please do not put comments after the patch, this made the second hunk
reject when I pulled it out of patchwork.
Anyways, fixed up and applied.
prev parent reply other threads:[~2012-04-30 17:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 10:22 bridge: Fix fatal typo in setup of multicast_querier_expired Herbert Xu
2012-04-30 16:04 ` Stephen Hemminger
2012-04-30 17:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120430.132738.647233864900000159.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).