From: David Miller <davem@davemloft.net>
To: ncardwell@google.com
Cc: ycheng@google.com, ilpo.jarvinen@helsinki.fi,
nanditad@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] tcp: fix infinite cwnd in tcp_complete_cwr()
Date: Mon, 30 Apr 2012 13:45:40 -0400 (EDT) [thread overview]
Message-ID: <20120430.134540.610433288172120407.davem@davemloft.net> (raw)
In-Reply-To: <CADVnQymFjqqT__kCN-0vqz+jqBLez7aoQZ14KEV5=m=Ed=Nayw@mail.gmail.com>
From: Neal Cardwell <ncardwell@google.com>
Date: Mon, 30 Apr 2012 12:25:56 -0400
> On Mon, Apr 30, 2012 at 12:00 PM, Yuchung Cheng <ycheng@google.com> wrote:
>> When the cwnd reduction is done, ssthresh may be infinite
>> if TCP enters CWR via ECN or F-RTO. If cwnd is not undone, i.e.,
>> undo_marker is set, tcp_complete_cwr() falsely set cwnd to the
>> infinite ssthresh value. The correct operation is to keep cwnd
>> intact because it has been updated in ECN or F-RTO.
>>
>> Signed-off-by: Yuchung Cheng <ycheng@google.com>
>> ---
>> ChangeLog since v1:
>> - Add snd_cwnd_stamp timestamping in CWR mode
>>
>> net/ipv4/tcp_input.c | 9 ++++++---
>> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> Acked-by: Neal Cardwell <ncardwell@google.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2012-04-30 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 16:00 [PATCH v2] tcp: fix infinite cwnd in tcp_complete_cwr() Yuchung Cheng
2012-04-30 16:25 ` Neal Cardwell
2012-04-30 17:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120430.134540.610433288172120407.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=nanditad@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).