From: David Miller <davem@davemloft.net>
To: roy.qing.li@gmail.com
Cc: netdev@vger.kernel.org, richardcochran@gmail.com, tshimizu818@gmail.com
Subject: Re: [PATCH net-next] pch_gbe: reprogram multicast address register on reset
Date: Mon, 30 Apr 2012 21:47:27 -0400 (EDT) [thread overview]
Message-ID: <20120430.214727.2237869140591442277.davem@davemloft.net> (raw)
In-Reply-To: <1335592421-31406-1-git-send-email-roy.qing.li@gmail.com>
From: roy.qing.li@gmail.com
Date: Sat, 28 Apr 2012 13:53:41 +0800
> From: RongQing.Li <roy.qing.li@gmail.com>
>
> The reset logic after a Rx FIFO overrun will clear the programmed
> multicast addresses. This patch fixes the issue by reprogramming the
> registers after the reset.
>
> The commit eefc48b tried to fix this problem, but it introduces
> unnecessary codes. In fact, all multicast addresses have been saved
> in netdev->mc, So we can call pch_gbe_set_multi() directly after
> reset_hw and reset_rx.
>
> This commit kills 50+ line codes
>
> Cc: Richard Cochran <richardcochran@gmail.com>
> Cc: Takahiro Shimizu <tshimizu818@gmail.com>
> Signed-off-by: RongQing.Li <roy.qing.li@gmail.com>
Applied.
prev parent reply other threads:[~2012-05-01 1:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 5:53 [PATCH net-next] pch_gbe: reprogram multicast address register on reset roy.qing.li
2012-04-28 16:41 ` Richard Cochran
2012-05-01 1:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120430.214727.2237869140591442277.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=roy.qing.li@gmail.com \
--cc=tshimizu818@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).