From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] bridge: make brctl showstp display port id Date: Mon, 30 Apr 2012 09:07:47 -0700 Message-ID: <20120430090747.1d64198b@nehalam.linuxnetplumber.net> References: <1335775148-5191-1-git-send-email-Joakim.Tjernlund@transmode.se> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" To: Joakim Tjernlund Return-path: Received: from mail.vyatta.com ([76.74.103.46]:44181 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754947Ab2D3QHv (ORCPT ); Mon, 30 Apr 2012 12:07:51 -0400 In-Reply-To: <1335775148-5191-1-git-send-email-Joakim.Tjernlund@transmode.se> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 30 Apr 2012 10:39:08 +0200 Joakim Tjernlund wrote: > My brctl showstp br0 always shows a 0 port id: > eth2 (1) > port id 0 state disabled > designated root 8000.00069c00b2fb path cost 100 > > because port id is printed as a hex number in sys fs. Change the > two hex occurrences(port no and port id) to decimal, just like all > the other numbers in this area. > > Signed-off-by: Joakim Tjernlund > --- > net/bridge/br_sysfs_if.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c > index fd5799c..9c4c2eb 100644 > --- a/net/bridge/br_sysfs_if.c > +++ b/net/bridge/br_sysfs_if.c > @@ -86,13 +86,13 @@ static BRPORT_ATTR(designated_cost, S_IRUGO, show_designated_cost, NULL); > > static ssize_t show_port_id(struct net_bridge_port *p, char *buf) > { > - return sprintf(buf, "0x%x\n", p->port_id); > + return sprintf(buf, "%d\n", p->port_id); > } > static BRPORT_ATTR(port_id, S_IRUGO, show_port_id, NULL); > > static ssize_t show_port_no(struct net_bridge_port *p, char *buf) > { > - return sprintf(buf, "0x%x\n", p->port_no); > + return sprintf(buf, "%d\n", p->port_no); > } > > static BRPORT_ATTR(port_no, S_IRUGO, show_port_no, NULL); No. This would be a visible change to applications. The bridge utilities should be fixed instead.