* [RFC][PATCH] net: ipv4: ipconfig: decrease CONF_CARRIER_TIMEOUT
@ 2012-05-02 15:24 Christian Hemp
2012-05-02 15:59 ` David Laight
2012-05-02 23:43 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Christian Hemp @ 2012-05-02 15:24 UTC (permalink / raw)
To: davem, kuznet, jmorris, yoshfuji, kaber, netdev; +Cc: Christian Hemp
A timeout of two minutes is pretty anoying if _no_ ethernet cable
is attached by purpose. This patch decreases the timeout of
CONF_CARRIER_TIMEOUT to an accaptable value of 10 secounds.
Signed-off-by: Christian Hemp <c.hemp@phytec.de>
---
net/ipv4/ipconfig.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 99ec116..2aa80ac 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -89,7 +89,7 @@
/* Define the friendly delay before and after opening net devices */
#define CONF_POST_OPEN 10 /* After opening: 10 msecs */
-#define CONF_CARRIER_TIMEOUT 120000 /* Wait for carrier timeout */
+#define CONF_CARRIER_TIMEOUT 1000 /* Wait for carrier timeout */
/* Define the timeout for waiting for a DHCP/BOOTP/RARP reply */
#define CONF_OPEN_RETRIES 2 /* (Re)open devices twice */
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [RFC][PATCH] net: ipv4: ipconfig: decrease CONF_CARRIER_TIMEOUT
2012-05-02 15:24 [RFC][PATCH] net: ipv4: ipconfig: decrease CONF_CARRIER_TIMEOUT Christian Hemp
@ 2012-05-02 15:59 ` David Laight
2012-05-02 23:43 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Laight @ 2012-05-02 15:59 UTC (permalink / raw)
To: Christian Hemp, davem, kuznet, jmorris, yoshfuji, kaber, netdev
> A timeout of two minutes is pretty anoying if _no_ ethernet cable
> is attached by purpose. This patch decreases the timeout of
> CONF_CARRIER_TIMEOUT to an accaptable value of 10 secounds.
>
...
>
> /* Define the friendly delay before and after opening net devices */
> #define CONF_POST_OPEN 10 /* After
> opening: 10 msecs */
> -#define CONF_CARRIER_TIMEOUT 120000 /* Wait for carrier timeout */
> +#define CONF_CARRIER_TIMEOUT 1000 /* Wait for carrier timeout */
Doesn't that reduce it to 1 second!
I'm also not all sure how long it might take.
I'm sure there are some switches/routers that can take quite a while
do negotiate the link.
Usually noticed when dhcp takes links down and up as it assigns
an address.
David
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC][PATCH] net: ipv4: ipconfig: decrease CONF_CARRIER_TIMEOUT
2012-05-02 15:24 [RFC][PATCH] net: ipv4: ipconfig: decrease CONF_CARRIER_TIMEOUT Christian Hemp
2012-05-02 15:59 ` David Laight
@ 2012-05-02 23:43 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-05-02 23:43 UTC (permalink / raw)
To: c.hemp; +Cc: kuznet, jmorris, yoshfuji, kaber, netdev
From: Christian Hemp <c.hemp@phytec.de>
Date: Wed, 2 May 2012 17:24:19 +0200
> A timeout of two minutes is pretty anoying if _no_ ethernet cable
> is attached by purpose. This patch decreases the timeout of
> CONF_CARRIER_TIMEOUT to an accaptable value of 10 secounds.
>
> Signed-off-by: Christian Hemp <c.hemp@phytec.de>
It was increased to 2 minutes intentionally, therefore you better go
look into the history of why this was done and you better explain in
your commit message why those issues don't matter.
Otherwise your patch will be completely ignored.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-02 23:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-02 15:24 [RFC][PATCH] net: ipv4: ipconfig: decrease CONF_CARRIER_TIMEOUT Christian Hemp
2012-05-02 15:59 ` David Laight
2012-05-02 23:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).