* [PATCH 1/2] net: ucc_geth, increase no. of HW RX descriptors
@ 2012-04-30 8:36 Joakim Tjernlund
2012-04-30 8:36 ` [PATCH 2/2] ucc_geth: Add 16 bytes to max TX frame for VLANs Joakim Tjernlund
2012-05-03 0:10 ` [PATCH 1/2] net: ucc_geth, increase no. of HW RX descriptors David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Joakim Tjernlund @ 2012-04-30 8:36 UTC (permalink / raw)
To: netdev@vger.kernel.org; +Cc: Joakim Tjernlund
In a busy network we see ucc_geth is dropping RX pkgs every now
and then. Increase the RX queues HW descriptors from
16 to 32 to deal with this.
Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
---
drivers/net/ethernet/freescale/ucc_geth.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.h b/drivers/net/ethernet/freescale/ucc_geth.h
index 2e395a2..f71b3e7 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.h
+++ b/drivers/net/ethernet/freescale/ucc_geth.h
@@ -877,7 +877,7 @@ struct ucc_geth_hardware_statistics {
/* Driver definitions */
#define TX_BD_RING_LEN 0x10
-#define RX_BD_RING_LEN 0x10
+#define RX_BD_RING_LEN 0x20
#define TX_RING_MOD_MASK(size) (size-1)
#define RX_RING_MOD_MASK(size) (size-1)
--
1.7.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] ucc_geth: Add 16 bytes to max TX frame for VLANs
2012-04-30 8:36 [PATCH 1/2] net: ucc_geth, increase no. of HW RX descriptors Joakim Tjernlund
@ 2012-04-30 8:36 ` Joakim Tjernlund
2012-05-03 0:12 ` David Miller
2012-05-03 0:10 ` [PATCH 1/2] net: ucc_geth, increase no. of HW RX descriptors David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Joakim Tjernlund @ 2012-04-30 8:36 UTC (permalink / raw)
To: netdev@vger.kernel.org; +Cc: Joakim Tjernlund
Creating a VLAN interface on top of ucc_geth adds 4 bytes
to the frame and the HW controller is not prepared to
TX a frame bigger than 1518 bytes which is 4 bytes too
small for a full VLAN frame. Add 16 bytes which will handle
the a simple VLAN and leaves 12 bytes for future expansion.
Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
---
drivers/net/ethernet/freescale/ucc_geth.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
index ba2dc08..638c8cb 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -116,10 +116,10 @@ static struct ucc_geth_info ugeth_primary_info = {
.maxGroupAddrInHash = 4,
.maxIndAddrInHash = 4,
.prel = 7,
- .maxFrameLength = 1518,
+ .maxFrameLength = 1518+16, /* Add extra bytes for VLANs etc. */
.minFrameLength = 64,
- .maxD1Length = 1520,
- .maxD2Length = 1520,
+ .maxD1Length = 1520+16, /* Add extra bytes for VLANs etc. */
+ .maxD2Length = 1520+16, /* Add extra bytes for VLANs etc. */
.vlantype = 0x8100,
.ecamptr = ((uint32_t) NULL),
.eventRegMask = UCCE_OTHER,
--
1.7.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] net: ucc_geth, increase no. of HW RX descriptors
2012-04-30 8:36 [PATCH 1/2] net: ucc_geth, increase no. of HW RX descriptors Joakim Tjernlund
2012-04-30 8:36 ` [PATCH 2/2] ucc_geth: Add 16 bytes to max TX frame for VLANs Joakim Tjernlund
@ 2012-05-03 0:10 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2012-05-03 0:10 UTC (permalink / raw)
To: Joakim.Tjernlund; +Cc: netdev
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Date: Mon, 30 Apr 2012 10:36:54 +0200
> In a busy network we see ucc_geth is dropping RX pkgs every now
> and then. Increase the RX queues HW descriptors from
> 16 to 32 to deal with this.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-03 0:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-30 8:36 [PATCH 1/2] net: ucc_geth, increase no. of HW RX descriptors Joakim Tjernlund
2012-04-30 8:36 ` [PATCH 2/2] ucc_geth: Add 16 bytes to max TX frame for VLANs Joakim Tjernlund
2012-05-03 0:12 ` David Miller
2012-05-03 0:10 ` [PATCH 1/2] net: ucc_geth, increase no. of HW RX descriptors David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).