From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: levinsasha928@gmail.com, jchapman@katalix.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davej@redhat.com
Subject: Re: [PATCH v2] net: l2tp: unlock socket lock before returning from l2tp_ip_sendmsg
Date: Wed, 02 May 2012 21:05:09 -0400 (EDT) [thread overview]
Message-ID: <20120502.210509.1240046301942391500.davem@davemloft.net> (raw)
In-Reply-To: <1335969156.22133.570.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 02 May 2012 16:32:36 +0200
> On Wed, 2012-05-02 at 15:58 +0200, Sasha Levin wrote:
>> l2tp_ip_sendmsg could return without releasing socket lock, making it all the
>> way to userspace, and generating the following warning:
>>
>> [ 130.891594] ================================================
>> [ 130.894569] [ BUG: lock held when returning to user space! ]
>> [ 130.897257] 3.4.0-rc5-next-20120501-sasha #104 Tainted: G W
>> [ 130.900336] ------------------------------------------------
>> [ 130.902996] trinity/8384 is leaving the kernel with locks still held!
>> [ 130.906106] 1 lock held by trinity/8384:
>> [ 130.907924] #0: (sk_lock-AF_INET){+.+.+.}, at: [<ffffffff82b9503f>] l2tp_ip_sendmsg+0x2f/0x550
>>
>> Introduced by commit 2f16270 ("l2tp: Fix locking in l2tp_ip.c").
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
>> ---
>
> Oh well, please read Documentation/stable_kernel_rules.txt
>
> Also, David prefers to handle stable submissions himself for net tree.
>
> Anyway :
>
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2012-05-03 1:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 13:58 [PATCH v2] net: l2tp: unlock socket lock before returning from l2tp_ip_sendmsg Sasha Levin
2012-05-02 14:32 ` Eric Dumazet
2012-05-03 1:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502.210509.1240046301942391500.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=jchapman@katalix.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).