[PATCH net-next 0/4] be2net: fixes

[PATCH net-next 0/4] be2net: fixes

[Sathya Perla]

Pls apply.

Sathya Perla (4):
  be2net: add vlan/rx-mode/flow-control config to be_setup()
  be2net: refactor VF setup/teardown code into be_vf_setup/clear()
  be2net: don't create multiple TXQs in BE2
  be2net: don't create multiple RX/TX rings in multi channel mode

 drivers/net/ethernet/emulex/benet/be_cmds.c |   66 +++--
 drivers/net/ethernet/emulex/benet/be_cmds.h |   10 +-
 drivers/net/ethernet/emulex/benet/be_main.c |  362 +++++++++++++--------------
 3 files changed, 222 insertions(+), 216 deletions(-)

-- 
1.7.4

Re: [PATCH net-next 0/4] be2net: fixes

[David Miller]

From: Sathya Perla <sathya.perla@emulex.com>
Date: Mon, 24 Oct 2011 18:14:59 +0530

> Pls apply.
> 
> Sathya Perla (4):
>   be2net: add vlan/rx-mode/flow-control config to be_setup()
>   be2net: refactor VF setup/teardown code into be_vf_setup/clear()
>   be2net: don't create multiple TXQs in BE2
>   be2net: don't create multiple RX/TX rings in multi channel mode

Applied, but many of your commit messages were poorly formatted (lines
exceeding 80 columns) and patches #1 and #2 had several trailing
whitespace errors.

I fixed this all up, but you have to be better than this.

RE: [PATCH net-next 0/4] be2net: fixes

[Sathya.Perla]

>-----Original Message-----
>From: David Miller [mailto:davem@davemloft.net]
>Sent: Tuesday, October 25, 2011 4:06 AM
>
>From: Sathya Perla <sathya.perla@emulex.com>
>Date: Mon, 24 Oct 2011 18:14:59 +0530
>
>> Pls apply.
>>
>> Sathya Perla (4):
>>   be2net: add vlan/rx-mode/flow-control config to be_setup()
>>   be2net: refactor VF setup/teardown code into be_vf_setup/clear()
>>   be2net: don't create multiple TXQs in BE2
>>   be2net: don't create multiple RX/TX rings in multi channel mode
>
>Applied, but many of your commit messages were poorly formatted (lines
>exceeding 80 columns) and patches #1 and #2 had several trailing
>whitespace errors.
>
>I fixed this all up, but you have to be better than this.
Dave, thanks. Will be careful....

[PATCH net-next 0/4] be2net fixes

[Sathya Perla]

Pls apply. Thanks.

Sathya Perla (4):
  be2net: init (vf)_if_handle/vf_pmac_id to handle failure scenarios
  be2net: stop checking the UE registers after an EEH error
  be2net: don't log more than one error on detecting EEH/UE errors
  be2net: stop issuing FW cmds if any cmd times out

 drivers/net/ethernet/emulex/benet/be.h      |   16 ++++---
 drivers/net/ethernet/emulex/benet/be_cmds.c |   49 +++++++-------------
 drivers/net/ethernet/emulex/benet/be_cmds.h |    4 +-
 drivers/net/ethernet/emulex/benet/be_main.c |   66 ++++++++++++++++-----------
 4 files changed, 69 insertions(+), 66 deletions(-)

-- 
1.7.4

Re: [PATCH net-next 0/4] be2net fixes

[David Miller]

From: Sathya Perla <sathya.perla@emulex.com>
Date: Fri, 11 Nov 2011 10:47:56 +0530

> Pls apply. Thanks.
> 
> Sathya Perla (4):
>   be2net: init (vf)_if_handle/vf_pmac_id to handle failure scenarios
>   be2net: stop checking the UE registers after an EEH error
>   be2net: don't log more than one error on detecting EEH/UE errors
>   be2net: stop issuing FW cmds if any cmd times out

All applied, thank you.

[PATCH net-next 0/4] be2net fixes

[Somnath Kotur]

Re-posting patches 1-4 from the earlier patch set of 5.
Incorporated review comment from Ben Hutchings in patch 2.
Will address comments in Patch 5 and send it out seperately.

Somnath Kotur (4):
  be2net: Fix to not set link speed for disabled functions of a UMC
    card
  be2net: Fix to apply duplex value as unknown when link is down.
  be2net: Record receive queue index in skb to aid RPS.
  be2net: Fix EEH error reset before a flash dump completes

 drivers/net/ethernet/emulex/benet/be_ethtool.c |    4 ++--
 drivers/net/ethernet/emulex/benet/be_main.c    |    7 +++++++
 2 files changed, 9 insertions(+), 2 deletions(-)

RE: [PATCH net-next 0/4] be2net fixes

[Somnath.Kotur]

David,
Have sent the 4 patches from the earlier patch series of 5 as is without updating the individual patch numbers i.e they still denote patch 1/5 etc.
Pls let me know if this is a problem and/or if you want me to resend them again? 

Thanks
Somnath

> -----Original Message-----
> From: Somnath Kotur [mailto:somnath.kotur@emulex.com]
> Sent: Wednesday, May 02, 2012 7:10 PM
> To: netdev@vger.kernel.org
> Cc: Kotur, Somnath
> Subject: [PATCH net-next 0/4] be2net fixes
> 
> Re-posting patches 1-4 from the earlier patch set of 5.
> Incorporated review comment from Ben Hutchings in patch 2.
> Will address comments in Patch 5 and send it out seperately.
> 
> Somnath Kotur (4):
>   be2net: Fix to not set link speed for disabled functions of a UMC
>     card
>   be2net: Fix to apply duplex value as unknown when link is down.
>   be2net: Record receive queue index in skb to aid RPS.
>   be2net: Fix EEH error reset before a flash dump completes
> 
>  drivers/net/ethernet/emulex/benet/be_ethtool.c |    4 ++--
>  drivers/net/ethernet/emulex/benet/be_main.c    |    7 +++++++
>  2 files changed, 9 insertions(+), 2 deletions(-)

Re: [PATCH net-next 0/4] be2net fixes

[David Miller]

From: Somnath Kotur <somnath.kotur@emulex.com>
Date: Wed, 2 May 2012 19:09:46 +0530

> Re-posting patches 1-4 from the earlier patch set of 5.
> Incorporated review comment from Ben Hutchings in patch 2.
> Will address comments in Patch 5 and send it out seperately.
> 
> Somnath Kotur (4):
>   be2net: Fix to not set link speed for disabled functions of a UMC
>     card
>   be2net: Fix to apply duplex value as unknown when link is down.
>   be2net: Record receive queue index in skb to aid RPS.
>   be2net: Fix EEH error reset before a flash dump completes

All applied, thanks.