From: David Miller <davem@davemloft.net>
To: gerard.lledo@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] sungem: Fix WakeOnLan
Date: Thu, 03 May 2012 01:43:30 -0400 (EDT) [thread overview]
Message-ID: <20120503.014330.1072601379213618284.davem@davemloft.net> (raw)
In-Reply-To: <1335639157-6336-1-git-send-email-gerard.lledo@gmail.com>
From: Gerard Lledo <gerard.lledo@gmail.com>
Date: Sat, 28 Apr 2012 21:52:37 +0300
> From: Gerard Lledo <gerard.lledo@gmail.com>
>
> WakeOnLan was broken in this driver because gp->asleep_wol is a 1-bit
> bitfield and it was being assigned WAKE_MAGIC, which is (1 << 5).
> gp->asleep_wol remains 0 and the machine never wakes up. Fixed by casting
> gp->wake_on_lan to bool. Tested on an iBook G4.
>
> Signed-off-by: Gerard Lledo <gerard.lledo@gmail.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2012-05-03 5:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 18:52 [PATCH] sungem: Fix WakeOnLan Gerard Lledo
2012-05-03 5:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120503.014330.1072601379213618284.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gerard.lledo@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).