* [PATCH] sungem: Fix WakeOnLan
@ 2012-04-28 18:52 Gerard Lledo
2012-05-03 5:43 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Gerard Lledo @ 2012-04-28 18:52 UTC (permalink / raw)
To: netdev; +Cc: davem, Gerard Lledo
From: Gerard Lledo <gerard.lledo@gmail.com>
WakeOnLan was broken in this driver because gp->asleep_wol is a 1-bit
bitfield and it was being assigned WAKE_MAGIC, which is (1 << 5).
gp->asleep_wol remains 0 and the machine never wakes up. Fixed by casting
gp->wake_on_lan to bool. Tested on an iBook G4.
Signed-off-by: Gerard Lledo <gerard.lledo@gmail.com>
---
drivers/net/ethernet/sun/sungem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c
index 558409f..4ba9690 100644
--- a/drivers/net/ethernet/sun/sungem.c
+++ b/drivers/net/ethernet/sun/sungem.c
@@ -2339,7 +2339,7 @@ static int gem_suspend(struct pci_dev *pdev, pm_message_t state)
netif_device_detach(dev);
/* Switch off chip, remember WOL setting */
- gp->asleep_wol = gp->wake_on_lan;
+ gp->asleep_wol = !!gp->wake_on_lan;
gem_do_stop(dev, gp->asleep_wol);
/* Unlock the network stack */
--
1.7.10
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sungem: Fix WakeOnLan
2012-04-28 18:52 [PATCH] sungem: Fix WakeOnLan Gerard Lledo
@ 2012-05-03 5:43 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-05-03 5:43 UTC (permalink / raw)
To: gerard.lledo; +Cc: netdev
From: Gerard Lledo <gerard.lledo@gmail.com>
Date: Sat, 28 Apr 2012 21:52:37 +0300
> From: Gerard Lledo <gerard.lledo@gmail.com>
>
> WakeOnLan was broken in this driver because gp->asleep_wol is a 1-bit
> bitfield and it was being assigned WAKE_MAGIC, which is (1 << 5).
> gp->asleep_wol remains 0 and the machine never wakes up. Fixed by casting
> gp->wake_on_lan to bool. Tested on an iBook G4.
>
> Signed-off-by: Gerard Lledo <gerard.lledo@gmail.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-03 5:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-28 18:52 [PATCH] sungem: Fix WakeOnLan Gerard Lledo
2012-05-03 5:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).