From: David Miller <davem@davemloft.net>
To: kkeil@linux-pingi.de
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3/8] Sometimes the ISDN chip only controls the D-channel
Date: Thu, 03 May 2012 02:50:59 -0400 (EDT) [thread overview]
Message-ID: <20120503.025059.1771068683530938115.davem@davemloft.net> (raw)
In-Reply-To: <4FA2265D.6040000@linux-pingi.de>
From: Karsten Keil <kkeil@linux-pingi.de>
Date: Thu, 03 May 2012 08:31:57 +0200
> I did put the additional PCM infrastructure in this series, because
> the approval test was done with it in place.
> I did plan the update of the low level drivers in a separate patchset
> from the beginning.
>
> What do you prefer, adding the driver part now, as additional patch, or
> removing this additional infrastruckture part and submit it in a later
> series ?
I feel like I'm talking to a wall.
A patch should do one, and only one thing. It should not have
changes which are unrelated to that one thing.
What part of this is so hard to understand?
To make matters worse, you didn't even make a mention of those
unrelated changes in your commit message.
So that patch was bogus on at least two counts.
next prev parent reply other threads:[~2012-05-03 6:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 11:43 [PATCH 0/8] mISDN: Collection of patches for layer1/layer2 Karsten Keil
2012-04-28 11:43 ` [PATCH 1/8] mISDN: Added PH_* state info to tei manager Karsten Keil
2012-04-28 11:43 ` [PATCH 2/8] mISDN: Fix refcounting bug Karsten Keil
2012-04-28 11:43 ` [PATCH 3/8] Sometimes the ISDN chip only controls the D-channel Karsten Keil
2012-05-01 17:30 ` David Miller
2012-05-03 6:31 ` Karsten Keil
2012-05-03 6:50 ` David Miller [this message]
2012-05-03 7:31 ` Karsten Keil
2012-05-03 8:08 ` David Miller
2012-04-28 11:43 ` [PATCH 4/8] mISDN: L2 timeouts need to be queued as L2 event Karsten Keil
2012-04-28 11:43 ` [PATCH 5/8] mISDN: Make layer1 timer 3 value configurable Karsten Keil
2012-04-28 11:43 ` [PATCH 6/8] mISDN: Layer1 statemachine fix Karsten Keil
2012-04-28 11:43 ` [PATCH 7/8] mISDN: Help to identify the card Karsten Keil
2012-04-28 11:43 ` [PATCH 8/8] mISDN: Add 2MBit mode for HFC E1 card Karsten Keil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120503.025059.1771068683530938115.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kkeil@linux-pingi.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).