From: David Miller <davem@davemloft.net>
To: bigeasy@linutronix.de
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net/niu: remove one superfluous dma mask check
Date: Thu, 03 May 2012 14:55:41 -0400 (EDT) [thread overview]
Message-ID: <20120503.145541.1415935370418437633.davem@davemloft.net> (raw)
In-Reply-To: <1336069320-23639-1-git-send-email-bigeasy@linutronix.de>
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: Thu, 3 May 2012 20:22:00 +0200
> The idea here seems to be to get a 44bit DMA mask working and if this
> fails it should fallback to a 32bit DMA mask. The dma_mask variable is
> assigned once to 44bit and never updated. pci_set_dma_mask() and
> pci_set_consistent_dma_mask() are both implemented as functions so there
> is no evil macro which might update dma_mask. Looking at the assembly, I
> see a call to dma_set_mask() followed by dma_supported() and then a jump
> passed the second dma_set_mask(). The only way to get to second
> dma_set_mask() call is by an error code in the first one.
>
> So I hereby remove the check since it looks superfluous. Please ignore
> the path if there is black magic involved.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
It looks like it's been this way since day one. :-)
Applied, thanks.
prev parent reply other threads:[~2012-05-03 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 18:22 [PATCH] net/niu: remove one superfluous dma mask check Sebastian Andrzej Siewior
2012-05-03 18:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120503.145541.1415935370418437633.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bigeasy@linutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).