netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.h.duyck@intel.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, jeffrey.t.kirsher@intel.com, edumazet@google.com
Subject: [v2 PATCH 0/4] Cleanup tcp_try_coalesce, fix module lockup on ixgbe
Date: Thu, 03 May 2012 00:18:54 -0700	[thread overview]
Message-ID: <20120503071141.13636.37564.stgit@gitlad.jf.intel.com> (raw)

This set represents the original patch I had done for trying to cleanup
tcp_try_coalesce broken into 3 patches.  The first one illustrates how I
believe we should be updating the truesize based on either the size of
sk_buff in the case of head reuse, or sk_buff plus the size of the head in
the case of a headlen of 0.

The other two patches go through and reorder things so there isn't as much
need for gotos.  I believe it makes the code much more readable since it
starts at the top and finishes at the bottom instead of looping through the
entire code path a few times.

The last patch addresses an issue I ran into on ixgbe.  It turns out the
recent HWMON patch added a but on 82598 adapters that caused the driver to
get hung in module unload.  I figured I would submit it directly since it
is a small change to fix an issue that could have a larger impact.

On that note I am going to sleep now and will respond to any reviews and/or
comments in the morning.

---

Alexander Duyck (4):
      ixgbe: Fix use after free on module remove
      tcp: move stats merge to the end of tcp_try_coalesce
      tcp: Move code related to head frag in tcp_try_coalesce
      tcp: Fix truesize accounting in tcp_try_coalesce


 drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c |    4 +
 net/ipv4/tcp_input.c                           |   83 +++++++++++++-----------
 2 files changed, 49 insertions(+), 38 deletions(-)

-- 

Thanks,

Alex

             reply	other threads:[~2012-05-03  7:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-03  7:18 Alexander Duyck [this message]
2012-05-03  7:18 ` [v2 PATCH 1/4] tcp: Fix truesize accounting in tcp_try_coalesce Alexander Duyck
2012-05-03  7:48   ` Eric Dumazet
2012-05-03  8:21     ` David Miller
2012-05-03  9:33   ` [PATCH net-next] net: Fix truesize accounting in skb_gro_receive() Eric Dumazet
2012-05-03 10:48     ` Alexander Duyck
2012-05-03 17:22     ` David Miller
2012-05-03  7:19 ` [v2 PATCH 2/4] tcp: Move code related to head frag in tcp_try_coalesce Alexander Duyck
2012-05-03  7:50   ` Eric Dumazet
2012-05-03  8:22     ` David Miller
2012-05-03  7:19 ` [v2 PATCH 3/4] tcp: move stats merge to the end of tcp_try_coalesce Alexander Duyck
2012-05-03  7:52   ` Eric Dumazet
2012-05-03  8:22     ` David Miller
2012-05-03  7:19 ` [v2 PATCH 4/4] ixgbe: Fix use after free on module remove Alexander Duyck
2012-05-03  8:22   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120503071141.13636.37564.stgit@gitlad.jf.intel.com \
    --to=alexander.h.duyck@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).