From: Amit Shah <amit.shah@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH RFC] virtio-net: remove useless disable on freeze
Date: Thu, 3 May 2012 16:29:59 +0530 [thread overview]
Message-ID: <20120503105959.GM13421@amit.redhat.com> (raw)
In-Reply-To: <20120404091954.GA3776@redhat.com>
On (Wed) 04 Apr 2012 [12:19:55], Michael S. Tsirkin wrote:
> disable_cb is just an optimization: it
> can not guarantee that there are no callbacks.
Even then, what's the harm in keeping it? If indeed there's an
attempt to raise an interrupt after the host has been notified, it
will be suppressed.
Also, disable_cb seems to be used elsewhere in the virtio_net.c file,
to suit similar purposes.
Amit
next prev parent reply other threads:[~2012-05-03 10:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 9:19 [PATCH RFC] virtio-net: remove useless disable on freeze Michael S. Tsirkin
2012-05-03 10:59 ` Amit Shah [this message]
2012-05-03 11:08 ` Michael S. Tsirkin
2012-05-28 12:53 ` Michael S. Tsirkin
2012-05-30 10:11 ` Rusty Russell
2012-05-31 8:35 ` Stephen Rothwell
2012-05-31 8:47 ` Michael S. Tsirkin
2012-05-31 9:04 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120503105959.GM13421@amit.redhat.com \
--to=amit.shah@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).