From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: johannes@sipsolutions.net, eric.dumazet@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: compare_ether_addr[_64bits]() has no ordering
Date: Tue, 08 May 2012 03:31:20 -0400 (EDT) [thread overview]
Message-ID: <20120508.033120.1272130362698029549.davem@davemloft.net> (raw)
In-Reply-To: <1336458936.29640.2.camel@joe2Laptop>
From: Joe Perches <joe@perches.com>
Date: Mon, 07 May 2012 23:35:36 -0700
> On Tue, 2012-05-08 at 02:26 -0400, David Miller wrote:
>> From: Johannes Berg <johannes@sipsolutions.net>
>> Date: Tue, 08 May 2012 07:25:44 +0200
>>
>> > I suppose I could fix those first and then later change the type, but I
>> > think having a "compare_ether_addr" function that returns *false* when
>> > they *match* would be rather confusing. I'd rather have
>> > "equal_ether_addr()" that returns *true* when they match.
>> >
>> > I guess we could introduce equal_ether_addr() though and slowly convert,
>> > keeping compare_ether_addr() as a sort of wrapper around it.
>>
>> Indeed, this is one way to proceed.
>
> perhaps is_equal_ether_addr or is_same_ether_addr instead?
Hmmm, my first choice would have been "eth_addr_equal()"
next prev parent reply other threads:[~2012-05-08 7:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 13:39 [PATCH] net: compare_ether_addr[_64bits]() has no ordering Johannes Berg
2012-05-07 13:53 ` Eric Dumazet
2012-05-07 14:12 ` Johannes Berg
2012-05-07 23:20 ` David Miller
2012-05-08 5:25 ` Johannes Berg
2012-05-08 6:26 ` David Miller
2012-05-08 6:35 ` Joe Perches
2012-05-08 7:31 ` David Miller [this message]
2012-05-08 16:44 ` Joe Perches
2012-05-08 16:44 ` [PATCH] etherdev.h: Convert int is_<foo>_ether_addr to bool Joe Perches
2012-05-08 17:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508.033120.1272130362698029549.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).