From: David Miller <davem@davemloft.net>
To: greearb@candelatech.com
Cc: cristian.chilipirea@gmail.com, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
daniel.baluta@gmail.com
Subject: Re: [PATCH] ipv4: Fixed checkpatch warnings and errors
Date: Tue, 08 May 2012 13:01:39 -0400 (EDT) [thread overview]
Message-ID: <20120508.130139.515602646900287732.davem@davemloft.net> (raw)
In-Reply-To: <4FA9382A.9090709@candelatech.com>
From: Ben Greear <greearb@candelatech.com>
Date: Tue, 08 May 2012 08:13:46 -0700
> On 05/08/2012 03:58 AM, Cristian Chilipirea wrote:
>> Fixed warnings and errors in af_inet.c.
>
>> #ifdef CONFIG_COMPAT
>> -static int inet_compat_ioctl(struct socket *sock, unsigned int cmd,
>> -unsigned long arg)
>> +static int inet_compat_ioctl(struct socket *sock, unsigned int cmd,
>> + unsigned long arg)
>> {
>
> That is so much worse than what was there before.
>
> Lets stop useless checkpatch crap on existing code
> unless it's really ugly.
Agreed, this patch is terrible.
prev parent reply other threads:[~2012-05-08 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 10:58 [PATCH] ipv4: Fixed checkpatch warnings and errors Cristian Chilipirea
2012-05-08 15:13 ` Ben Greear
2012-05-08 17:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508.130139.515602646900287732.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cristian.chilipirea@gmail.com \
--cc=daniel.baluta@gmail.com \
--cc=greearb@candelatech.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).