* [PATCH] net/bluetooth/bnep/core.c: use constant for ethertype
@ 2012-05-07 22:09 Eldad Zack
2012-05-09 4:09 ` Gustavo Padovan
0 siblings, 1 reply; 2+ messages in thread
From: Eldad Zack @ 2012-05-07 22:09 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, David S. Miller
Cc: linux-bluetooth, netdev, linux-kernel, Eldad Zack
The dot1q ethertype number (0x8100) is embedded in the code, although
it is already defined in included headers.
Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
---
net/bluetooth/bnep/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/bnep/core.c b/net/bluetooth/bnep/core.c
index a779ec7..4fab436 100644
--- a/net/bluetooth/bnep/core.c
+++ b/net/bluetooth/bnep/core.c
@@ -340,7 +340,7 @@ static inline int bnep_rx_frame(struct bnep_session *s, struct sk_buff *skb)
}
/* Strip 802.1p header */
- if (ntohs(s->eh.h_proto) == 0x8100) {
+ if (ntohs(s->eh.h_proto) == ETH_P_8021Q) {
if (!skb_pull(skb, 4))
goto badframe;
s->eh.h_proto = get_unaligned((__be16 *) (skb->data - 2));
--
1.7.10
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net/bluetooth/bnep/core.c: use constant for ethertype
2012-05-07 22:09 [PATCH] net/bluetooth/bnep/core.c: use constant for ethertype Eldad Zack
@ 2012-05-09 4:09 ` Gustavo Padovan
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo Padovan @ 2012-05-09 4:09 UTC (permalink / raw)
To: Eldad Zack
Cc: Marcel Holtmann, Johan Hedberg, David S. Miller, linux-bluetooth,
netdev, linux-kernel
Hi Eldad,
* Eldad Zack <eldad@fogrefinery.com> [2012-05-08 00:09:35 +0200]:
> The dot1q ethertype number (0x8100) is embedded in the code, although
> it is already defined in included headers.
>
> Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
> ---
> net/bluetooth/bnep/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch has been applied to bluetooth-next. Thanks.
Gustavo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-09 4:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-07 22:09 [PATCH] net/bluetooth/bnep/core.c: use constant for ethertype Eldad Zack
2012-05-09 4:09 ` Gustavo Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).