From: David Miller <davem@davemloft.net>
To: jchapman@katalix.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] l2tp: fix reorder timeout recovery
Date: Thu, 10 May 2012 23:27:50 -0400 (EDT) [thread overview]
Message-ID: <20120510.232750.775841370291639964.davem@davemloft.net> (raw)
In-Reply-To: <1336642989-4785-1-git-send-email-jchapman@katalix.com>
From: James Chapman <jchapman@katalix.com>
Date: Thu, 10 May 2012 10:43:08 +0100
> When L2TP data packet reordering is enabled, packets are held in a
> queue while waiting for out-of-sequence packets. If a packet gets
> lost, packets will be held until the reorder timeout expires, when we
> are supposed to then advance to the sequence number of the next packet
> but we don't currently do so. As a result, the data channel is stuck
> because we are waiting for a packet that will never arrive - all
> packets age out and none are passed.
>
> The fix is to add a flag to the session context, which is set when the
> reorder timeout expires and tells the receive code to reset the next
> expected sequence number to that of the next packet in the queue.
>
> Tested in a production L2TP network with Starent and Nortel L2TP gear.
>
> Signed-off-by: James Chapman <jchapman@katalix.com>
Applied, but reorder_skip should really be a 'bool'.
prev parent reply other threads:[~2012-05-11 3:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 9:43 [PATCH net-next 1/2] l2tp: fix reorder timeout recovery James Chapman
2012-05-10 9:43 ` [PATCH net-next 2/2] l2tp: fix data packet sequence number handling James Chapman
2012-05-11 3:27 ` David Miller
2012-05-11 3:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120510.232750.775841370291639964.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).