From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: pull request: batman-adv 2012-05-11 Date: Fri, 11 May 2012 18:01:44 -0400 (EDT) Message-ID: <20120511.180144.174337959525316777.davem@davemloft.net> References: <1336738892-7401-1-git-send-email-ordex@autistici.org> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org To: ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org Return-path: In-Reply-To: <1336738892-7401-1-git-send-email-ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org Errors-To: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org List-Id: netdev.vger.kernel.org From: Antonio Quartulli Date: Fri, 11 May 2012 14:21:17 +0200 > this is a fixed version of the pull request issued on 2012-05-09. > > Comments introduced in this patchset are not following the net-tree > guidelines. Another patch changing all the already existing comments will follow > later. > > New exported functions follow the new name convention we discussed so far. > A patch renaming all the existing exported functions will follow. Pulled, but you have to cleanup the namespace on lots of other functions too. For example, the packet receive handle register/unregister routines you added in this series as well. Go through the entire batman-adv stack, and if the function or data object is not static, make sure it has a batadv_*() prefix.