From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net-next v2 0/2][pull request] Intel Wired LAN Driver Updates
Date: Sat, 12 May 2012 15:27:50 -0400 (EDT) [thread overview]
Message-ID: <20120512.152750.1001784663174919311.davem@davemloft.net> (raw)
In-Reply-To: <20120512.152259.129063933510245955.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Sat, 12 May 2012 15:22:59 -0400 (EDT)
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Sat, 12 May 2012 02:11:56 -0700
>
>> This series of patches contains updates for igb. Most notably,
>> the addition of i210 & i211 support.
>>
>> v2: fix up patch 2 based on feedback from David Miller
>>
>> The following are changes since commit 06a4c1c55dbe5d9f7a708e8f1a52fd2ac8e5874f:
>> 6lowpan: IPv6 link local address
>> and are available in the git repository at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
>
> Pulled, thanks.
Actually, I unpulled.
These changes introduce a new compiler warning because mrqc is now
only set conditionally and the code is such that the compiler cannot
see whether or not mrqc is only used when it is in fact set.
Please re-arrange the code so that this warning will not occur.
drivers/net/ethernet/intel/igb/igb_main.c: In function ‘igb_configure’:
drivers/net/ethernet/intel/igb/igb_main.c:2903:7: warning: ‘mrqc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/net/ethernet/intel/igb/igb_main.c:2806:6: note: ‘mrqc’ was declared here
prev parent reply other threads:[~2012-05-12 19:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-12 9:11 [net-next v2 0/2][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-05-12 9:11 ` [net-next 1/2] igb: Add function and pointers for 82580 low power state settings Jeff Kirsher
2012-05-12 9:11 ` [net-next v2 2/2] igb: Add Support for new i210/i211 devices Jeff Kirsher
2012-05-12 19:22 ` [net-next v2 0/2][pull request] Intel Wired LAN Driver Updates David Miller
2012-05-12 19:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120512.152750.1001784663174919311.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).