From: Florian Westphal <fw@strlen.de>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Alban Crequy <alban.crequy@collabora.co.uk>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Vincent Sanders <vincent.sanders@collabora.co.uk>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/6] netfilter: decnet: switch hook PFs to nfproto
Date: Mon, 14 May 2012 16:22:49 +0200 [thread overview]
Message-ID: <20120514142249.GA9778@breakpoint.cc> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B6F0A@saturn3.aculab.com>
David Laight <David.Laight@ACULAB.COM> wrote:
>
> > NFPROTO_* constants were usually equal to PF_* constants but it is not
> > necessary and it will waste less memory if we don't do so
> > (see commit 7e9c6e
> > "netfilter: Introduce NFPROTO_* constants")
> ...
> >
> > static struct nf_hook_ops dnrmg_ops __read_mostly = {
> > .hook = dnrmg_hook,
> > - .pf = PF_DECnet,
> > + .pf = NFPROTO_DECNET,
> > .hooknum = NF_DN_ROUTE,
> > .priority = NF_DN_PRI_DNRTMSG,
> > };
>
> Might it be worth renaming the .pf member to (say) .nfproto
> to help avoid confusion?
NFPROTO_* values are exported to userspace, so I don't think
its safe to change these values.
next prev parent reply other threads:[~2012-05-14 14:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 13:56 [PATCH 1/6] netfilter: sanity checks on NFPROTO_NUMPROTO Alban Crequy
2012-05-14 13:56 ` [PATCH 2/6] netfilter: decnet: switch hook PFs to nfproto Alban Crequy
2012-05-14 14:18 ` David Laight
2012-05-14 14:22 ` Florian Westphal [this message]
2012-05-14 14:38 ` Pablo Neira Ayuso
2012-05-14 15:06 ` Jan Engelhardt
2012-05-14 14:45 ` Pablo Neira Ayuso
2012-06-06 0:02 ` Pablo Neira Ayuso
2012-05-14 13:56 ` [PATCH 3/6] netfilter: bridge: " Alban Crequy
2012-06-06 0:03 ` Pablo Neira Ayuso
2012-05-14 13:56 ` [PATCH 4/6] netfilter: ipv4, defrag: " Alban Crequy
2012-06-06 0:03 ` Pablo Neira Ayuso
2012-05-14 13:56 ` [PATCH 5/6] netfilter: ipvs: " Alban Crequy
2012-06-06 0:03 ` Pablo Neira Ayuso
2012-05-14 13:56 ` [PATCH 6/6] netfilter: selinux: " Alban Crequy
2012-06-06 0:03 ` Pablo Neira Ayuso
2012-05-14 14:42 ` [PATCH 1/6] netfilter: sanity checks on NFPROTO_NUMPROTO Pablo Neira Ayuso
2012-05-14 15:39 ` Alban Crequy
2012-05-14 16:04 ` [PATCH v2 " Alban Crequy
2012-05-14 19:04 ` Pablo Neira Ayuso
2012-05-15 12:32 ` [PATCH v3 " Alban Crequy
2012-05-14 15:00 ` [PATCH " Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514142249.GA9778@breakpoint.cc \
--to=fw@strlen.de \
--cc=David.Laight@ACULAB.COM \
--cc=alban.crequy@collabora.co.uk \
--cc=javier.martinez@collabora.co.uk \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=vincent.sanders@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).