From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Alban Crequy <alban.crequy@collabora.co.uk>,
Patrick McHardy <kaber@trash.net>,
Vincent Sanders <vincent.sanders@collabora.co.uk>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] [RFC] netfilter: don't assume NFPROTO_* are like PF_*
Date: Mon, 14 May 2012 21:06:35 +0200 [thread overview]
Message-ID: <20120514190635.GE14897@1984> (raw)
In-Reply-To: <alpine.LNX.2.01.1205141707490.11548@frira.vanv.qr>
On Mon, May 14, 2012 at 05:09:54PM +0200, Jan Engelhardt wrote:
>
> On Monday 2012-05-14 15:58, Alban Crequy wrote:
> >--- a/include/linux/netfilter.h
> >+++ b/include/linux/netfilter.h
> >@@ -62,11 +62,11 @@ enum nf_inet_hooks {
> >
> > enum {
> > NFPROTO_UNSPEC = 0,
> >- NFPROTO_IPV4 = 2,
> >- NFPROTO_ARP = 3,
> >- NFPROTO_BRIDGE = 7,
> >- NFPROTO_IPV6 = 10,
> >- NFPROTO_DECNET = 12,
> >+ NFPROTO_IPV4,
> >+ NFPROTO_ARP,
> >+ NFPROTO_BRIDGE,
> >+ NFPROTO_IPV6,
> >+ NFPROTO_DECNET,
> > NFPROTO_NUMPROTO,
> > };
>
> This must not be changed under any circumstances. It is exported to
> and used by userspace. (Except perhaps for NFPROTO_DECNET, which
> refers to a quite dead protocol that I think no user parts have ever
> used NFPROTO_DECNET.) I would consider it acceptable to change the
> value for NFPROTO_DECNET if Pablo joins.
If there is some remote posibility to break userspace code, I won't
take the patch, sorry.
prev parent reply other threads:[~2012-05-14 19:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 13:58 [PATCH] [RFC] netfilter: don't assume NFPROTO_* are like PF_* Alban Crequy
2012-05-14 15:09 ` Jan Engelhardt
2012-05-14 15:42 ` Alban Crequy
2012-05-14 19:06 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514190635.GE14897@1984 \
--to=pablo@netfilter.org \
--cc=alban.crequy@collabora.co.uk \
--cc=javier.martinez@collabora.co.uk \
--cc=jengelh@inai.de \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=vincent.sanders@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).