From: David Miller <davem@davemloft.net>
To: ogerlitz@mellanox.com
Cc: roland@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/8] net/mlx4: Address build warnings on set but not used variables
Date: Tue, 15 May 2012 01:59:16 -0400 (EDT) [thread overview]
Message-ID: <20120515.015916.1228365475475285173.davem@davemloft.net> (raw)
In-Reply-To: <4FB1EF06.6070909@mellanox.com>
From: Or Gerlitz <ogerlitz@mellanox.com>
Date: Tue, 15 May 2012 08:52:06 +0300
> On 5/15/2012 7:07 AM, David Miller wrote:
>>
>>> - err = mlx4_qp_detach_common(dev,&qp, rgid->gid, rgid->prot,
>>> + (void) mlx4_qp_detach_common(dev,&qp, rgid->gid, rgid->prot,
>>> rgid->steer);
>>
>> You must update the indentation of all the lines comprising of the
>> function call when you change the indentation of it's initial line.
>
> Just want to make sure I understood right what has to be done here,
> e.g in this case its needs to be
> like this?
...
>> - rgid->steer);
>> + (void) mlx4_qp_detach_common(dev, &qp, rgid->gid, rgid->prot,
>> + rgid->steer);
I can't tell if it's right, becuase it got all reformatted by your
mail client.
You simply need to make sure the arguments on the second and
further lines line up with the column after the openning
parenthesis on the first line.
next prev parent reply other threads:[~2012-05-15 5:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 20:04 [PATCH net-next 0/8] batch of mlx4 driver fixes Or Gerlitz
2012-05-14 20:04 ` [PATCH net-next 1/8] net/mlx4: Address build warnings on set but not used variables Or Gerlitz
2012-05-15 4:07 ` David Miller
2012-05-15 5:52 ` Or Gerlitz
2012-05-15 5:59 ` David Miller [this message]
2012-05-15 6:16 ` Or Gerlitz
2012-05-14 20:04 ` [PATCH net-next 2/8] net/mlx4_core: Fix init_port mask state for slaves Or Gerlitz
2012-05-14 20:04 ` [PATCH net-next 3/8] net/mlx4_core: Change SYNC_TPT to be native (not wrapped) Or Gerlitz
2012-05-14 20:04 ` [PATCH net-next 4/8] net/mlx4_core: Remove unused *_str functions from the resource tracker Or Gerlitz
2012-05-14 20:04 ` [PATCH net-next 5/8] net/mlx4_core: Do not reset module-parameter num_vfs when fail to enable sriov Or Gerlitz
2012-05-14 20:04 ` [PATCH net-next 6/8] net/mlx4_core: Fix potential kernel Oops in res tracker during Dom0 driver unload Or Gerlitz
2012-05-14 20:04 ` [PATCH net-next 7/8] net/mlx4_core: Add XRC domains and counters to resource tracker Or Gerlitz
2012-05-14 20:04 ` [PATCH net-next 8/8] net/mlx4_core: Fixed error flow in rem_slave_eqs Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515.015916.1228365475475285173.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=roland@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox