* Re: [PATCH v3.4-rc7 regression] net/bond: return int from recv_probe()
[not found] ` <201205151056.53621.arnd@arndb.de>
@ 2012-05-15 17:07 ` David Miller
2012-05-15 17:08 ` David Miller
1 sibling, 0 replies; 2+ messages in thread
From: David Miller @ 2012-05-15 17:07 UTC (permalink / raw)
To: arnd; +Cc: geert, jbohac, linux-kernel, netdev
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 15 May 2012 10:56:53 +0000
> 13a8e0c8c "bonding: don't increase rx_dropped after processing LACPDUs"
> changed the prototype of the bonding recv_probe handler, but only in
> some places, as identified by this warning:
>
> drivers/net/bonding/bond_main.c: In function 'bond_handle_frame':
> drivers/net/bonding/bond_main.c:1463:13: error: assignment from incompatible pointer type [-Werror]
> drivers/net/bonding/bond_main.c: In function 'bond_open':
> drivers/net/bonding/bond_main.c:3441:21: error: assignment from incompatible pointer type [-Werror]
> drivers/net/bonding/bond_main.c:3448:20: error: assignment from incompatible pointer type [-Werror]
>
> To fix this, we can change the remaining prototypes to return an
> integer as well, and always return RX_HANDLER_ANOTHER from rlb_arp_recv.
This has been fixed in Linus's tree for almost 2 days.
^ permalink raw reply [flat|nested] 2+ messages in thread