From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: andy.cress@us.kontron.com, netdev@vger.kernel.org
Subject: Re: [PATCH] pch_gbe: fix transmit races
Date: Tue, 15 May 2012 13:43:00 -0400 (EDT) [thread overview]
Message-ID: <20120515.134300.588180020194758538.davem@davemloft.net> (raw)
In-Reply-To: <1337023566.8512.622.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 14 May 2012 21:26:06 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> Andy reported pch_gbe triggered "NETDEV WATCHDOG" errors.
>
> May 11 11:06:09 kontron kernel: WARNING: at net/sched/sch_generic.c:261
> dev_watchdog+0x1ec/0x200() (Not tainted)
> May 11 11:06:09 kontron kernel: Hardware name: N/A
> May 11 11:06:09 kontron kernel: NETDEV WATCHDOG: eth0 (pch_gbe):
> transmit queue 0 timed out
>
> It seems pch_gbe has a racy tx path (races with TX completion path)
>
> Remove tx_queue_lock lock since it has no purpose, we must use tx_lock
> instead.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Andy Cress <andy.cress@us.kontron.com>
> Tested-by: Andy Cress <andy.cress@us.kontron.com>
Applied.
prev parent reply other threads:[~2012-05-15 17:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 20:48 pch_gbe: oops with vlan (new) Andy Cress
2012-05-11 21:12 ` Eric Dumazet
2012-05-11 22:10 ` Eric Dumazet
2012-05-14 16:40 ` pch_gbe: oops with vlan (resolved) Andy Cress
2012-05-14 19:26 ` [PATCH] pch_gbe: fix transmit races Eric Dumazet
2012-05-15 17:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515.134300.588180020194758538.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy.cress@us.kontron.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).