From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next 2/2] net: ipv4 and ipv6: Convert printk(KERN_DEBUG to pr_debug Date: Tue, 15 May 2012 18:35:36 -0700 Message-ID: <20120515183536.2cac1e29@nehalam.linuxnetplumber.net> References: <1fd8285e798ec9b3817c790a67b2bb655ffc931b.1337126963.git.joe@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Joe Perches Return-path: In-Reply-To: <1fd8285e798ec9b3817c790a67b2bb655ffc931b.1337126963.git.joe@perches.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 15 May 2012 17:11:54 -0700 Joe Perches wrote: > Use the current debugging style and enable dynamic_debug. > > Signed-off-by: Joe Perches This changes the action of the system. By default: printk(KERN_DEBUG "foo\n"); is enabled all the time and prints to log with debug level. But your version pr_debug("foo\n"); defaults to being dropped until the system is built with dynamic debug, and that particular debug instance is enabled. Since these are all useful, but low priority messages, not I don't think disabling them by default is such a great idea now.