From: Arnd Bergmann <arnd@arndb.de>
To: Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com>
Cc: s.hauer@pengutronix.de, gfm@funxed.com, davem@davemloft.net,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org
Subject: Re: [PATCH V2] CS89x0 : Use ioread16/iowrite16 on all platforms
Date: Tue, 15 May 2012 21:22:15 +0000 [thread overview]
Message-ID: <201205152122.15840.arnd@arndb.de> (raw)
In-Reply-To: <1337112906-31033-1-git-send-email-jaccon.bastiaansen@gmail.com>
On Tuesday 15 May 2012, Jaccon Bastiaansen wrote:
>
> The use of the inw/outw functions by the cs89x0 platform driver
> results in NULL pointer references on ARM platforms and
> platforms that do not provide ISA-style programmed I/O accessors.
>
> Using inw/outw also accesses the wrong address space on platforms
> that have a PCI I/O space that is not identity-mapped into the
> physical address space.
>
> Signed-off-by: Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com>
Looks good to me now.
Acked-by: Arnd Bergmann <arnd@arndb.de>
Of course we would need some testing on another platform and ideally
also on an ISA based machine, although that might be hard to
come by these days...
Arnd
next prev parent reply other threads:[~2012-05-15 21:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 20:15 [PATCH V2] CS89x0 : Use ioread16/iowrite16 on all platforms Jaccon Bastiaansen
2012-05-15 21:22 ` Arnd Bergmann [this message]
2012-05-15 22:37 ` Francois Romieu
2012-05-15 23:08 ` Joe Perches
2012-05-16 7:20 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205152122.15840.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=gfm@funxed.com \
--cc=jaccon.bastiaansen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).