From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: ppp/l2tp doing oversized allocations ? Date: Sat, 19 May 2012 00:46:52 -0400 (EDT) Message-ID: <20120519.004652.2261671316587735315.davem@davemloft.net> References: <20120514162923.GA4439@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kernel-team@fedoraproject.org, edumazet@google.com To: davej@redhat.com Return-path: Received: from shards.monkeyblade.net ([198.137.202.13]:47269 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806Ab2ESEq4 (ORCPT ); Sat, 19 May 2012 00:46:56 -0400 In-Reply-To: <20120514162923.GA4439@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Dave Jones Date: Mon, 14 May 2012 12:29:23 -0400 > We just got this trace from reported by a Fedora user running 3.3.4 > > :WARNING: at mm/page_alloc.c:2204 __alloc_pages_nodemask+0x231/0x8f0() > :Call Trace: > : [] warn_slowpath_common+0x7f/0xc0 > : [] warn_slowpath_null+0x1a/0x20 > : [] __alloc_pages_nodemask+0x231/0x8f0 > : [] ? dev_queue_xmit+0x1db/0x640 > : [] ? ip_forward_options+0x1f0/0x1f0 > : [] ? neigh_direct_output+0x11/0x20 > : [] ? ip_finish_output+0x17e/0x2f0 > : [] ? ip_forward_options+0x1f0/0x1f0 > : [] alloc_pages_current+0xa3/0x110 > : [] __get_free_pages+0x14/0x50 > : [] kmalloc_order_trace+0x3f/0xd0 > : [] ? xfrm4_output_finish+0x27/0x40 > : [] __kmalloc+0x177/0x1a0 > : [] ? ip_queue_xmit+0x156/0x400 > : [] pskb_expand_head+0x87/0x310 > : [] ? __mod_zone_page_state+0x49/0x50 > : [] pppol2tp_xmit+0x1ed/0x220 [l2tp_ppp] So it's ESP encapsulated IPSEC over L2tp. Eric, I wonder if session->hdr_len can take on undesirable values and thus trip up the skb COW'ing calculations you added?