* [PATCH] phy/micrel: Fix ID of KSZ9021
@ 2012-05-22 0:20 Nobuhiro Iwamatsu
2012-05-22 19:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Nobuhiro Iwamatsu @ 2012-05-22 0:20 UTC (permalink / raw)
To: netdev; +Cc: david.choi, Nobuhiro Iwamatsu
Right ID of KSZ9021 is 0x00221610.
Because lower 4bit is a revision number, it varies according to a chip.
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Cc: David J. Choi <david.choi@micrel.com>
---
include/linux/micrel_phy.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/micrel_phy.h b/include/linux/micrel_phy.h
index dd8da34..61f0905 100644
--- a/include/linux/micrel_phy.h
+++ b/include/linux/micrel_phy.h
@@ -3,7 +3,7 @@
#define MICREL_PHY_ID_MASK 0x00fffff0
-#define PHY_ID_KSZ9021 0x00221611
+#define PHY_ID_KSZ9021 0x00221610
#define PHY_ID_KS8737 0x00221720
#define PHY_ID_KS8041 0x00221510
#define PHY_ID_KS8051 0x00221550
--
1.7.10
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy/micrel: Fix ID of KSZ9021
2012-05-22 0:20 [PATCH] phy/micrel: Fix ID of KSZ9021 Nobuhiro Iwamatsu
@ 2012-05-22 19:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-05-22 19:21 UTC (permalink / raw)
To: nobuhiro.iwamatsu.yj; +Cc: netdev, david.choi
From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Date: Tue, 22 May 2012 09:20:08 +0900
> Right ID of KSZ9021 is 0x00221610.
> Because lower 4bit is a revision number, it varies according to a chip.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Applied, but this shouldn't matter and it should not have any
effect on functionality.
All of the code knows how to properly mask out the revision because
of MICRL_PHY_ID_MASK and the the .phy_id_mask specified in the
ksz9021_driver entry.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-22 19:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-22 0:20 [PATCH] phy/micrel: Fix ID of KSZ9021 Nobuhiro Iwamatsu
2012-05-22 19:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).