public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>, Dave Taht <dave.taht@bufferbloat.net>
Subject: Re: [PATCH iproute2] tc_codel: Controlled Delay AQM
Date: Tue, 22 May 2012 14:16:10 -0700	[thread overview]
Message-ID: <20120522141610.601f68ed@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1336717355.31653.130.camel@edumazet-glaptop>

On Fri, 11 May 2012 08:22:35 +0200
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> From: Eric Dumazet <edumazet@google.com>
> 
> An implementation of CoDel AQM, from Kathleen Nichols and Van Jacobson. 
> 
> http://queue.acm.org/detail.cfm?id=2209336 
> 
> This AQM main input is no longer queue size in bytes or packets, but the
> delay packets stay in (FIFO) queue.
> 
> As we don't have infinite memory, we still can drop packets in enqueue()
> in case of massive load, but mean of CoDel is to drop packets in
> dequeue(), using a control law based on two simple parameters :
> 
> target : target sojourn time (default 5ms)
> interval : width of moving time window (default 100ms)
> 
> Selected packets are dropped, unless ECN is enabled and packets can get
> ECN mark instead.
> 
> Usage: tc qdisc ... codel [ limit PACKETS ] [ target TIME ]
>                           [ interval TIME ] [ ecn ]
> 
> qdisc codel 10: parent 1:1 limit 2000p target 3.0ms interval 60.0ms ecn 
>  Sent 13347099587 bytes 8815805 pkt (dropped 0, overlimits 0 requeues 0) 
>  rate 202365Kbit 16708pps backlog 113550b 75p requeues 0 
>   count 116 lastcount 98 ldelay 4.3ms dropping drop_next 816us
>   maxpacket 1514 ecn_mark 84399 drop_overlimit 0
> 
> CoDel must be seen as a base module, and should be used keeping in mind
> there is still a FIFO queue. So a typical setup will probably need a
> hierarchy of several qdiscs and packet classifiers to be able to meet
> whatever constraints a user might have.
> 
> One possible example would be to use fq_codel, which combines Fair
> Queueing and CoDel, in replacement of sfq / sfq_red.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Dave Taht <dave.taht@bufferbloat.net>
> ---
> Notes :
> 1) : Dave Taht will send a nice man-page for this stuff.
> 2) : the TCA_NETEM_ECN bit is because of include/linux/pkt_sched.h sync
> with net-next
>      (I'll send a separate patch for netem)
> 

Applied. Used 3.5 sanitized header (not the one in your patch),
and fixed whitespace error.


Ok, where's the man page :-)

  reply	other threads:[~2012-05-22 21:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11  6:22 [PATCH iproute2] tc_codel: Controlled Delay AQM Eric Dumazet
2012-05-22 21:16 ` Stephen Hemminger [this message]
2012-05-22 23:59   ` Dave Taht
2012-05-23  2:05     ` Vijay Subramanian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120522141610.601f68ed@nehalam.linuxnetplumber.net \
    --to=shemminger@vyatta.com \
    --cc=dave.taht@bufferbloat.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox