netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Wunderlich <simon.wunderlich-Y4E02TeZ33kaBlGTGt4zH4SGEyLTKazZ@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org,
	lindner_marek-LWAfsSFWpa4@public.gmane.org
Subject: Re: [PATCH 06/15] batman-adv: Distributed ARP Table - add snooping functions for ARP messages
Date: Thu, 24 May 2012 10:09:55 +0200	[thread overview]
Message-ID: <20120524080955.GA14941@pandem0nium> (raw)
In-Reply-To: <20120524.015457.1543147002306809286.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

Hey David,

thanks for your answer,

On Thu, May 24, 2012 at 01:54:57AM -0400, David Miller wrote:
> From: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org>
> Date: Thu, 24 May 2012 07:34:12 +0200
> 
> > _You_ were the person that declined the pull request because _you_ wanted to 
> > rewrite the ARP handling. So _you_ are the person that has the insight in 
> > _your_ plans. Either _you_ tell us what is _your_ problem with it or _you_ 
> > will have to point us to a person that knows _you_.
> 
> If I say that you must not use ARP nor neighbour layer internals, it
> doesn't mean that I have to come up with the alternative
> implementation for you.

well, thats pretty much answers it. If we must not use ARP or neighbour
internals, even after your rewrite (?), we have to come up with an alternative
in any case (write our own backened).

We don't expect you to come up with an alternative implementation, but
as you are the one accepting the patches (or not) we need to know why
you decline something and what the problem is so we ca n work around
or improve.

Thanks
	Simon

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  parent reply	other threads:[~2012-05-24  8:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-29  8:57 pull request: batman-adv 2012-04-29 Antonio Quartulli
     [not found] ` <1335689867-8017-1-git-send-email-ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
2012-04-29  8:57   ` [PATCH 01/15] batman-adv: add UNICAST_4ADDR packet type Antonio Quartulli
2012-04-29  8:57   ` [PATCH 02/15] batman-adv: add a new log level for DAT debugging Antonio Quartulli
2012-04-29  8:57   ` [PATCH 03/15] batman-adv: add biggest_unsigned_int(x) macro Antonio Quartulli
2012-04-29  8:57 ` [PATCH 04/15] batman-adv: Distributed ARP Table - create DHT helper functions Antonio Quartulli
2012-04-29  8:57 ` [PATCH 05/15] batman-adv: Distributed ARP Table - add ARP parsing functions Antonio Quartulli
2012-04-29  8:57 ` [PATCH 06/15] batman-adv: Distributed ARP Table - add snooping functions for ARP messages Antonio Quartulli
     [not found]   ` <1335689867-8017-7-git-send-email-ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
2012-04-30 17:05     ` David Miller
     [not found]       ` <20120430.130555.48557916635285475.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-04-30 22:22         ` Antonio Quartulli
     [not found]           ` <20120430222226.GB21977-E/2OGukznS5g9hUCZPvPmw@public.gmane.org>
2012-05-01  0:59             ` David Miller
     [not found]               ` <20120430.205904.288157818941040253.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-05-12  8:26                 ` Marek Lindner
     [not found]                   ` <201205121626.38520.lindner_marek-LWAfsSFWpa4@public.gmane.org>
2012-05-17 11:53                     ` Marek Lindner
     [not found]                       ` <201205171953.54891.lindner_marek-LWAfsSFWpa4@public.gmane.org>
2012-05-23 21:48                         ` Simon Wunderlich
2012-05-23 23:01                           ` David Miller
     [not found]                             ` <20120523.190158.2172815395820691292.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-05-24  5:34                               ` Sven Eckelmann
     [not found]                                 ` <3476925.EJY4MZoOgZ-1RWNDQYo44h8XcdJbWeDu3TFMtCCXL7YSoIsB4E12gc@public.gmane.org>
2012-05-24  5:54                                   ` David Miller
     [not found]                                     ` <20120524.015457.1543147002306809286.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-05-24  8:09                                       ` Simon Wunderlich [this message]
2012-04-29  8:57 ` [PATCH 07/15] batman-adv: Distributed ARP Table - increase default soft_iface ARP table timeout Antonio Quartulli
2012-04-29  8:57 ` [PATCH 08/15] batman-adv: Distributed ARP Table - add compile option Antonio Quartulli
2012-04-29  8:57 ` [PATCH 09/15] batman-adv: fix wrong dhcp option list browsing Antonio Quartulli
2012-04-29  8:57 ` [PATCH 10/15] batman-adv: introduce is_single_hop_neigh variable to increase readability Antonio Quartulli
2012-04-29  8:57 ` [PATCH 11/15] batman-adv: introduce packet type handler array for incoming packets Antonio Quartulli
2012-04-29  8:57 ` [PATCH 12/15] batman-adv: register batman ogm receive function during protocol init Antonio Quartulli
2012-04-29  8:57 ` [PATCH 13/15] batman-adv: rename last_valid to last_seen Antonio Quartulli
2012-04-29  8:57 ` [PATCH 14/15] batman-adv: replace HZ calculations with jiffies_to_msecs() Antonio Quartulli
2012-04-29  8:57 ` [PATCH 15/15] batman-adv: split neigh_new function into generic and batman iv specific parts Antonio Quartulli
  -- strict thread matches above, loose matches on Subject: below --
2012-04-25 13:26 pull request: batman-adv 2012-04-25 Antonio Quartulli
2012-04-25 13:27 ` [PATCH 06/15] batman-adv: Distributed ARP Table - add snooping functions for ARP messages Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120524080955.GA14941@pandem0nium \
    --to=simon.wunderlich-y4e02tez33kablgtgt4zh4sgeyltkazz@public.gmane.org \
    --cc=b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=lindner_marek-LWAfsSFWpa4@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).