From: David Miller <davem@davemloft.net>
To: florian@openwrt.org
Cc: devendra.aaru@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] r6040: disable pci device if the subsequent calls (after pci_enable_device) fails
Date: Tue, 29 May 2012 17:28:43 -0400 (EDT) [thread overview]
Message-ID: <20120529.172843.1775456038320356018.davem@davemloft.net> (raw)
In-Reply-To: <20120529.172229.277102319861990758.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 29 May 2012 17:22:29 -0400 (EDT)
> From: Florian Fainelli <florian@openwrt.org>
> Date: Tue, 29 May 2012 11:20:50 +0200
>
>> On Monday 28 May 2012 17:27:03 Devendra Naga wrote:
>>> the calls after the pci_enable_device may fail, and will error out with out
>>> disabling it. disable the device at error paths.
>>
>> Looks good, thanks Devendra!
>>
>>>
>>> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
>>
>> Acked-by: Florian Fainelli <florian@openwrt.org>
>
> Applied.
Actually, reverted, you didn't test this patch at all.
You didn't even look at the warnings emitted by the compiler
with your changes installed.
You're passing a network device pointer into the PCI device
disable routine, which takes a PCI device pointer.
I can't express to you how extremely irritating it is when
people submit patches like this.
The bug in question is 1,000 times less harmful than your fix.
next prev parent reply other threads:[~2012-05-29 21:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 11:57 [PATCH] r6040: disable pci device if the subsequent calls (after pci_enable_device) fails Devendra Naga
2012-05-29 9:20 ` Florian Fainelli
2012-05-29 9:58 ` devendra.aaru
2012-05-29 10:06 ` Florian Fainelli
2012-05-29 10:13 ` devendra.aaru
2012-05-29 21:22 ` David Miller
2012-05-29 21:28 ` David Miller [this message]
2012-05-29 23:19 ` devendra.aaru
-- strict thread matches above, loose matches on Subject: below --
2012-05-29 23:14 Devendra Naga
2012-05-29 23:18 ` David Miller
2012-05-29 23:22 ` devendra.aaru
2012-05-29 23:24 ` David Miller
2012-05-29 23:34 ` devendra.aaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120529.172843.1775456038320356018.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devendra.aaru@gmail.com \
--cc=florian@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).