From: David Miller <davem@davemloft.net>
To: eldad@fogrefinery.com
Cc: kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 8021q/vlan: process NETDEV_GOING_DOWN
Date: Wed, 30 May 2012 17:50:20 -0400 (EDT) [thread overview]
Message-ID: <20120530.175020.1714406888633137662.davem@davemloft.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1205302344200.8234@debianer>
From: Eldad Zack <eldad@fogrefinery.com>
Date: Wed, 30 May 2012 23:47:32 +0200 (CEST)
>
> On Wed, 30 May 2012, David Miller wrote:
>> From: Eldad Zack <eldad@fogrefinery.com>
>> Date: Wed, 30 May 2012 21:11:02 +0200 (CEST)
>>
>> > In case a certain protocol needs to send a "dying gasp" packet, when you
>> > administrativly shutdown the port (which is also what happens when you
>> > restart the machine).
>>
>> No in tree users have this requirement, therefore your patch is
>> inappropriate.
>
> You are right in that, that no in tree users have this requirement
> (yet), but in the same time it doesn't harm any existing code.
>
> Don't you agree that it's the right order to do the notifications?
It's not an issue that matters upstream, so I simply do not care.
When you, or someone else, submits code that needs this facility
then we can talk about it.
Otherwise it's just a waste of our time.
next prev parent reply other threads:[~2012-05-30 21:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 22:30 [PATCH] 8021q/vlan: process NETDEV_GOING_DOWN Eldad Zack
2012-05-30 0:40 ` David Miller
2012-05-30 19:11 ` Eldad Zack
2012-05-30 20:27 ` David Miller
2012-05-30 21:47 ` Eldad Zack
2012-05-30 21:50 ` David Miller [this message]
2012-05-30 22:02 ` Eldad Zack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120530.175020.1714406888633137662.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eldad@fogrefinery.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).