* [PATCH net 1/3] bql: Fix POSDIFF() to integer overflow aware.
@ 2012-05-30 22:24 Hiroaki SHIMODA
2012-05-31 7:58 ` Eric Dumazet
2012-05-31 22:19 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Hiroaki SHIMODA @ 2012-05-30 22:24 UTC (permalink / raw)
To: davem; +Cc: therbert, eric.dumazet, denys, netdev
POSDIFF() fails to take into account integer overflow case.
Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Cc: Tom Herbert <therbert@google.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Denys Fedoryshchenko <denys@visp.net.lb>
---
lib/dynamic_queue_limits.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/dynamic_queue_limits.c b/lib/dynamic_queue_limits.c
index 6ab4587..c87eb76 100644
--- a/lib/dynamic_queue_limits.c
+++ b/lib/dynamic_queue_limits.c
@@ -10,7 +10,7 @@
#include <linux/jiffies.h>
#include <linux/dynamic_queue_limits.h>
-#define POSDIFF(A, B) ((A) > (B) ? (A) - (B) : 0)
+#define POSDIFF(A, B) ((int)((A) - (B)) > 0 ? (A) - (B) : 0)
/* Records completed count and recalculates the queue limit */
void dql_completed(struct dql *dql, unsigned int count)
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net 1/3] bql: Fix POSDIFF() to integer overflow aware.
2012-05-30 22:24 [PATCH net 1/3] bql: Fix POSDIFF() to integer overflow aware Hiroaki SHIMODA
@ 2012-05-31 7:58 ` Eric Dumazet
2012-05-31 22:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2012-05-31 7:58 UTC (permalink / raw)
To: Hiroaki SHIMODA; +Cc: davem, therbert, denys, netdev
On Thu, 2012-05-31 at 07:24 +0900, Hiroaki SHIMODA wrote:
> POSDIFF() fails to take into account integer overflow case.
>
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
> Cc: Tom Herbert <therbert@google.com>
> Cc: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Denys Fedoryshchenko <denys@visp.net.lb>
> ---
> lib/dynamic_queue_limits.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/dynamic_queue_limits.c b/lib/dynamic_queue_limits.c
> index 6ab4587..c87eb76 100644
> --- a/lib/dynamic_queue_limits.c
> +++ b/lib/dynamic_queue_limits.c
> @@ -10,7 +10,7 @@
> #include <linux/jiffies.h>
> #include <linux/dynamic_queue_limits.h>
>
> -#define POSDIFF(A, B) ((A) > (B) ? (A) - (B) : 0)
> +#define POSDIFF(A, B) ((int)((A) - (B)) > 0 ? (A) - (B) : 0)
>
> /* Records completed count and recalculates the queue limit */
> void dql_completed(struct dql *dql, unsigned int count)
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net 1/3] bql: Fix POSDIFF() to integer overflow aware.
2012-05-30 22:24 [PATCH net 1/3] bql: Fix POSDIFF() to integer overflow aware Hiroaki SHIMODA
2012-05-31 7:58 ` Eric Dumazet
@ 2012-05-31 22:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-05-31 22:19 UTC (permalink / raw)
To: shimoda.hiroaki; +Cc: therbert, eric.dumazet, denys, netdev
From: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Date: Thu, 31 May 2012 07:24:39 +0900
> POSDIFF() fails to take into account integer overflow case.
>
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-31 22:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-30 22:24 [PATCH net 1/3] bql: Fix POSDIFF() to integer overflow aware Hiroaki SHIMODA
2012-05-31 7:58 ` Eric Dumazet
2012-05-31 22:19 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).