From: David Miller <davem@davemloft.net>
To: jasowang@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com
Subject: Re: [PATCH 2/2] 8139cp/8139too: terminate the eeprom access with the right opmode
Date: Fri, 01 Jun 2012 14:23:17 -0400 (EDT) [thread overview]
Message-ID: <20120601.142317.1843610571282799477.davem@davemloft.net> (raw)
In-Reply-To: <20120601041948.4311.42372.stgit@dhcp-8-146.nay.redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Fri, 01 Jun 2012 12:19:48 +0800
> Currently, we terminate the eeprom access through clearing the CS by:
>
> RTL_W8 (Cfg9346, ~EE_CS); or writeb (~EE_CS, ee_addr);
>
> This would left the eeprom into "Config. Register Write Enable:"
> state which is not expcted as the highest two bits were set to
> 0x11 ( expected is the "Normal" mode (0x00)). Solving this by write
> 0x0 instead of ~EE_CS when terminating the eeprom access.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Applied.
next prev parent reply other threads:[~2012-06-01 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 4:19 [PATCH 1/2] 8139cp: set ring address before enabling receiver Jason Wang
2012-06-01 4:19 ` [PATCH 2/2] 8139cp/8139too: terminate the eeprom access with the right opmode Jason Wang
2012-06-01 18:23 ` David Miller [this message]
2012-06-01 18:23 ` [PATCH 1/2] 8139cp: set ring address before enabling receiver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120601.142317.1843610571282799477.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).