From: Alessandro Rubini <rubini@gnudd.com>
To: anilkumar@ti.com
Cc: mkl@pengutronix.de, bhupesh.sharma@st.com,
federico.vaga@gmail.com, alan@lxorguk.ukuu.org.uk,
wg@grandegger.com, giancarlo.asnaghi@st.com,
alan@linux.intel.com, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] c_can_pci: generic module for c_can on PCI
Date: Tue, 5 Jun 2012 18:50:09 +0200 [thread overview]
Message-ID: <20120605165008.GA21871@mail.gnudd.com> (raw)
In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13E9CB18A@DBDE01.ent.ti.com>
> I am late to the discussion, is there any specific reason to maintain a
> separate platform file (c_can_pci.c).
Because it depends on pci and ifdef is bad.
> I think 90% of the code is copied from c_can_paltform.c, code
> changes will be less if you merge to existing c_can platform driver.
Yes, but then we need to ifdef around, which merges two bad files
into a single but worse file.
But since the only current user of c_can is the platform device, why
not merging the platform with the core and having pci just register a
platform device? The only problem I see is that we need cooperation,
because neither me nor federico have a c_can equipped board besides
the pci one.
thanks
/alessandro
next prev parent reply other threads:[~2012-06-05 16:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 20:59 [PATCH] STA2X11 CAN: CAN driver for the STA2X11 board Federico Vaga
2012-05-18 6:00 ` Wolfgang Grandegger
2012-05-26 8:36 ` Federico Vaga
2012-05-26 19:57 ` Wolfgang Grandegger
2012-06-04 13:32 ` generic module for c-can on pci Federico Vaga
2012-06-04 13:32 ` [PATCH RFC] c_can_pci: generic module for c_can on PCI Federico Vaga
2012-06-04 14:04 ` Marc Kleine-Budde
2012-06-12 14:25 ` Federico Vaga
2012-06-12 14:46 ` Marc Kleine-Budde
2012-06-12 14:53 ` Federico Vaga
2012-06-04 15:56 ` Alan Cox
2012-06-04 16:45 ` Federico Vaga
2012-06-05 3:42 ` Bhupesh SHARMA
2012-06-05 11:19 ` Federico Vaga
2012-06-05 13:04 ` Bhupesh SHARMA
2012-06-05 13:13 ` Alessandro Rubini
2012-06-05 13:21 ` Marc Kleine-Budde
2012-06-05 13:22 ` Bhupesh SHARMA
2012-06-05 13:30 ` Alessandro Rubini
2012-06-05 15:12 ` AnilKumar, Chimata
2012-06-05 16:50 ` Alessandro Rubini [this message]
2012-06-06 3:50 ` Bhupesh SHARMA
2012-06-11 13:18 ` Federico Vaga
2012-06-11 14:21 ` Wolfgang Grandegger
2012-06-04 16:45 ` Alessandro Rubini
2012-06-11 13:51 ` Wolfgang Grandegger
2012-06-11 14:23 ` Alessandro Rubini
2012-06-11 14:09 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605165008.GA21871@mail.gnudd.com \
--to=rubini@gnudd.com \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=anilkumar@ti.com \
--cc=bhupesh.sharma@st.com \
--cc=federico.vaga@gmail.com \
--cc=giancarlo.asnaghi@st.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).