From mboxrd@z Thu Jan 1 00:00:00 1970 From: Raffaele Recalcati Subject: Re: [patch] net/ethernet: ks8851_mll unregister_netdev() before freeing Date: Wed, 6 Jun 2012 19:03:11 +0200 Message-ID: <20120606170311.GB3382@recalcati> References: <20120606063129.GA26829@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter Return-path: Received: from mx2.bticino.it ([91.208.195.91]:49873 "EHLO bticino.it" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756906Ab2FFRSb (ORCPT ); Wed, 6 Jun 2012 13:18:31 -0400 In-Reply-To: <20120606063129.GA26829@elgon.mountain> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: On 09:31 Wed 06 Jun , Dan Carpenter wrote: > We added another error condition here, but if we were to hit it then > we need to unregister_netdev() before doing the free_netdev(). > Otherwise we would hit the BUG_ON() in free_netdev(): > > BUG_ON(dev->reg_state != NETREG_UNREGISTERED); > > Signed-off-by: Dan Carpenter > --- > Static checker stuff. I don't have this hardware. > > diff --git a/drivers/net/ethernet/micrel/ks8851_mll.c b/drivers/net/ethernet/micrel/ks8851_mll.c > index 70bd329..875dd5e 100644 > --- a/drivers/net/ethernet/micrel/ks8851_mll.c > +++ b/drivers/net/ethernet/micrel/ks8851_mll.c > @@ -1606,7 +1606,7 @@ static int __devinit ks8851_probe(struct platform_device *pdev) > if (!pdata) { > netdev_err(netdev, "No platform data\n"); > err = -ENODEV; > - goto err_register; > + goto err_pdata; > } > memcpy(ks->mac_addr, pdata->mac_addr, 6); > if (!is_valid_ether_addr(ks->mac_addr)) { > @@ -1626,6 +1626,8 @@ static int __devinit ks8851_probe(struct platform_device *pdev) > (id >> 8) & 0xff, (id >> 4) & 0xf, (id >> 1) & 0x7); > return 0; > > +err_pdata: > + unregister_netdev(netdev); > err_register: > err_get_irq: > iounmap(ks->hw_addr_cmd); Tested-by: Raffaele Recalcati [ 2.274993] ks8851_mll ks8851_mll: (unregistered net_device): message enable is 0 [ 2.282897] ks8851_mll ks8851_mll: (unregistered net_device): the selftest passes [ 2.302246] ks8851_mll ks8851_mll: eth0: No platform data