From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org, wfg@linux.intel.com
Subject: Re: [PATCH (net.git) V2] stmmac: fix driver built w/ w/o both pci and platf modules
Date: Thu, 07 Jun 2012 11:01:30 -0700 (PDT) [thread overview]
Message-ID: <20120607.110130.1448306195184899614.davem@davemloft.net> (raw)
In-Reply-To: <1339073322-23093-1-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Thu, 7 Jun 2012 14:48:42 +0200
> + pr_err("stmmac: do not register the PCI driver\n");
This is inappropriate, since this is called unconditionally.
next prev parent reply other threads:[~2012-06-07 18:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 9:53 [PATCH (net.git)] stmmac: fix driver built w/ w/o both pci and platf modules Giuseppe CAVALLARO
2012-06-07 12:48 ` [PATCH (net.git) V2] " Giuseppe CAVALLARO
2012-06-07 13:38 ` Fengguang Wu
2012-06-07 18:01 ` David Miller [this message]
2012-06-08 5:25 ` [PATCH (net.git) V3] " Giuseppe CAVALLARO
2012-06-08 5:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607.110130.1448306195184899614.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=wfg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).