* [PATCH] ipv6: fib: Restore NTF_ROUTER exception in fib6_age()
@ 2012-06-07 16:51 Thomas Graf
2012-06-07 20:03 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Graf @ 2012-06-07 16:51 UTC (permalink / raw)
To: davem; +Cc: netdev
Commit 5339ab8b1dd82 (ipv6: fib: Convert fib6_age() to
dst_neigh_lookup().) seems to have mistakenly inverted the
exception for cached NTF_ROUTER routes.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
---
net/ipv6/ip6_fib.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
index 0c220a4..74c21b9 100644
--- a/net/ipv6/ip6_fib.c
+++ b/net/ipv6/ip6_fib.c
@@ -1561,7 +1561,7 @@ static int fib6_age(struct rt6_info *rt, void *arg)
neigh_flags = neigh->flags;
neigh_release(neigh);
}
- if (neigh_flags & NTF_ROUTER) {
+ if (!(neigh_flags & NTF_ROUTER)) {
RT6_TRACE("purging route %p via non-router but gateway\n",
rt);
return -1;
--
1.7.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv6: fib: Restore NTF_ROUTER exception in fib6_age()
2012-06-07 16:51 [PATCH] ipv6: fib: Restore NTF_ROUTER exception in fib6_age() Thomas Graf
@ 2012-06-07 20:03 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-06-07 20:03 UTC (permalink / raw)
To: tgraf; +Cc: netdev
From: Thomas Graf <tgraf@suug.ch>
Date: Thu, 7 Jun 2012 18:51:04 +0200
> Commit 5339ab8b1dd82 (ipv6: fib: Convert fib6_age() to
> dst_neigh_lookup().) seems to have mistakenly inverted the
> exception for cached NTF_ROUTER routes.
>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
Thanks for fixing this, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-07 20:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-07 16:51 [PATCH] ipv6: fib: Restore NTF_ROUTER exception in fib6_age() Thomas Graf
2012-06-07 20:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).