netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Remove out of date message in appletalk printk
@ 2012-06-06 18:45 Dave Jones
  2012-06-07 20:12 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2012-06-06 18:45 UTC (permalink / raw)
  To: netdev; +Cc: acme

I accidentally triggered this printk, which amused me for a few moments.
Given we're post 2.2, we could just -EACCES, but does anyone even care about Appletalk now ?
I figure it's better to leave sleeping dogs lie, and just update the message.

Signed-off-by: Dave Jones <davej@redhat.com>

diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index 0301b32..12e9100 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -1208,9 +1208,7 @@ static int atalk_connect(struct socket *sock, struct sockaddr *uaddr,
 	if (addr->sat_addr.s_node == ATADDR_BCAST &&
 	    !sock_flag(sk, SOCK_BROADCAST)) {
 #if 1
-		printk(KERN_WARNING "%s is broken and did not set "
-				    "SO_BROADCAST. It will break when 2.2 is "
-				    "released.\n",
+		printk(KERN_WARNING "%s is broken and did not set SO_BROADCAST.\n",
 			current->comm);
 #else
 		return -EACCES;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Remove out of date message in appletalk printk
  2012-06-06 18:45 Remove out of date message in appletalk printk Dave Jones
@ 2012-06-07 20:12 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-06-07 20:12 UTC (permalink / raw)
  To: davej; +Cc: netdev, acme

From: Dave Jones <davej@redhat.com>
Date: Wed, 6 Jun 2012 14:45:59 -0400

> I accidentally triggered this printk, which amused me for a few moments.
> Given we're post 2.2, we could just -EACCES, but does anyone even care about Appletalk now ?
> I figure it's better to leave sleeping dogs lie, and just update the message.
> 
> Signed-off-by: Dave Jones <davej@redhat.com>

Applied, but I made a few refinements.  I made it use pr_warn() and
also prefixed the message with "atalk_connect: " so if someone sees
this it's easier to figure out where it's coming from.

Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-07 20:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-06 18:45 Remove out of date message in appletalk printk Dave Jones
2012-06-07 20:12 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).