From: David Miller <davem@davemloft.net>
To: sr@denx.de
Cc: netdev@vger.kernel.org, viresh.linux@gmail.com, peppe.cavallaro@st.com
Subject: Re: [PATCH] net: stmmac: Fix clock en-/disable calls
Date: Thu, 07 Jun 2012 13:13:58 -0700 (PDT) [thread overview]
Message-ID: <20120607.131358.813782810012986816.davem@davemloft.net> (raw)
In-Reply-To: <1338965351-6286-1-git-send-email-sr@denx.de>
From: Stefan Roese <sr@denx.de>
Date: Wed, 6 Jun 2012 08:49:11 +0200
> Signed-off-by: Stefan Roese <sr@denx.de>
This means nothing to me.
What is fixed by using the prepare/unprepare variants vs. the
plain ones?
It is absolutely inappropriate to not describe your change
completely in your commit message.
This patch is being rejected.
prev parent reply other threads:[~2012-06-07 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 6:49 [PATCH] net: stmmac: Fix clock en-/disable calls Stefan Roese
2012-06-07 20:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607.131358.813782810012986816.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=sr@denx.de \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).