From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2 1/2] inetpeer: add namespace support for inetpeer Date: Thu, 07 Jun 2012 14:43:01 -0700 (PDT) Message-ID: <20120607.144301.1259354794384347085.davem@davemloft.net> References: <1338882737-11914-1-git-send-email-gaofeng@cn.fujitsu.com> <20120606.104323.1698446129331745479.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: steffen.klassert-opNxpl+3fjRBDgjK7y7TUQ@public.gmane.org, herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org, eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org To: gaofeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org Return-path: In-Reply-To: <20120606.104323.1698446129331745479.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: netdev.vger.kernel.org From: David Miller Date: Wed, 06 Jun 2012 10:43:23 -0700 (PDT) > So I'm dropping these two patches and will work on the mentioned > approach to this fix. It turns out that even if I move the inetpeer roots into the FIB rules layer, we still need your changes Gao. But your patches are corrupted. For example, in this patch, the final hunk for net/ipv4/inetpeer.c has no differences only context. That's an extremely corrupted patch. Please resolve this, and add the NULL pointer settings during network namespace shutdown that Eric Dumazet asked for. Thanks.