From: David Miller <davem@davemloft.net>
To: sfking@fdwdc.com
Cc: jan.ceuleers@computer.org, netdev@vger.kernel.org,
uclinux-dev@uclinux.org, gerg@snapgear.com
Subject: Re: [PATCH net-next] fec: Add support for Coldfire M5441x enet-mac.
Date: Thu, 07 Jun 2012 14:47:47 -0700 (PDT) [thread overview]
Message-ID: <20120607.144747.1809368718789038860.davem@davemloft.net> (raw)
In-Reply-To: <201206061305.48893.sfking@fdwdc.com>
From: Steven King <sfking@fdwdc.com>
Date: Wed, 6 Jun 2012 13:05:48 -0700
> On Wednesday 06 June 2012 10:34:21 am Jan Ceuleers wrote:
>> On 06/06/2012 07:06 PM, Steven King wrote:
>> > Add support for the Freescale Coldfire M5441x; as these parts have an
>> > enet-mac, add a quirk to distinguish them from the other Coldfire parts
>> > so we can use the existing enet-mac support.
>>
>> Stephen,
>>
>> You are activating certain functionality based on whether M5441x is
>> defined. But where is this being defined? Should this not be added in a
>> Kconfig somewhere as a platform option?
>
> Yes. Hopefully, once I send Greg my updated patches to add support for the
> m5441x, then it will be a selection in the m68k port. I just happened to
> have these ready to go after David chastised me for sending them too late in
> the last merge cycle...
I don't see any point in applying this before the necessary infrastructure
this depend upon is in the tree.
Therefore I'm not applying this.
prev parent reply other threads:[~2012-06-07 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 17:06 [PATCH net-next] fec: Add support for Coldfire M5441x enet-mac Steven King
2012-06-06 17:34 ` Jan Ceuleers
2012-06-06 20:05 ` Steven King
2012-06-07 21:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607.144747.1809368718789038860.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gerg@snapgear.com \
--cc=jan.ceuleers@computer.org \
--cc=netdev@vger.kernel.org \
--cc=sfking@fdwdc.com \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).