From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: therbert@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH] bonding: Fix corrupted queue_mapping
Date: Thu, 07 Jun 2012 23:22:27 -0700 (PDT) [thread overview]
Message-ID: <20120607.232227.1902940919233969170.davem@davemloft.net> (raw)
In-Reply-To: <1339136238.6001.28.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 08 Jun 2012 08:17:18 +0200
> On Thu, 2012-06-07 at 23:02 -0700, David Miller wrote:
>
>> Hmmm, isn't that what qdisc_skb_cb is for? And even private data is
>> explicitly allocated:
>>
>> > unsigned char data[24];
>>
>> there. :-)
>>
>
> By the way, I notice data[] is not aligned on a long on 64bit arches.
>
> This might break net/sched/sch_netem.c on some arches, since
> time_to_send is a u64.
Looks like we'll get the bonding queue mapping and fix this alignment
bug for free then :-)
prev parent reply other threads:[~2012-06-08 6:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 5:05 [PATCH] bonding: Fix corrupted queue_mapping Tom Herbert
2012-06-08 5:46 ` David Miller
2012-06-08 5:57 ` Eric Dumazet
2012-06-08 6:02 ` David Miller
2012-06-08 6:11 ` Eric Dumazet
2012-06-08 6:15 ` David Miller
2012-06-08 6:47 ` Eric Dumazet
2012-06-08 7:23 ` Eric Dumazet
2012-06-08 7:42 ` John Fastabend
2012-06-08 7:48 ` Eric Dumazet
2012-06-08 7:52 ` Eric Dumazet
2012-06-08 7:46 ` Eric Dumazet
2012-06-08 15:04 ` Tom Herbert
2012-06-08 15:11 ` Eric Dumazet
2012-06-08 16:16 ` John Fastabend
2012-06-08 6:17 ` Eric Dumazet
2012-06-08 6:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607.232227.1902940919233969170.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).