From: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Tom Herbert <therbert@google.com>,
Denys Fedoryshchenko <denys@visp.net.lb>,
<netdev@vger.kernel.org>, <e1000-devel@lists.sourceforge.net>,
<jeffrey.t.kirsher@intel.com>, <davem@davemloft.net>
Subject: Re: Strange latency spikes/TX network stalls on Sun Fire X4150(x86) and e1000e
Date: Thu, 7 Jun 2012 02:19:37 +0900 [thread overview]
Message-ID: <20120607021937.a5638bfd.shimoda.hiroaki@gmail.com> (raw)
In-Reply-To: <20120606092635.00003b61@unknown>
On Wed, 6 Jun 2012 09:26:35 -0700
Jesse Brandeburg <jesse.brandeburg@intel.com> wrote:
> On Wed, 6 Jun 2012 Hiroaki SHIMODA <shimoda.hiroaki@gmail.com> wrote:
> > Sorry for long delay. I'll post.
> > (I have no idea how to fix this problem as keeping TXDCTL.WTHRESH to 5)
>
> I don't like changing WTHRESH wholesale because making the global change
> to WTHRESH on e1000e just to fix this one bug (likely specific to a
> particular chip/hardware) will adversely effect performance on many
> models supported by e1000e not demonstrating any problem. We could
> possibly check something in for just ESB2LAN (S5000 chipset).
>
> Other people (tom herbert) with this same chipset have been unable to
> reproduce this issue right?
I understand your performance concern.
The affected chip would be e1000_82571, e1000_82572, e1000_82574
and e1000_80003es2lan which have FLAG2_DMA_BURST bit in
adapter->flags2.
Anyway, I have no objection intel guys NACK to my patch and
provide right fix. But in that case please consider 82574L chip too
which I observed similar behaviour.
Thanks.
next prev parent reply other threads:[~2012-06-06 17:19 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 14:15 Strange latency spikes/TX network stalls on Sun Fire X4150(x86) and e1000e Denys Fedoryshchenko
2012-05-17 13:42 ` Denys Fedoryshchenko
2012-05-17 16:54 ` Denys Fedoryshchenko
2012-05-18 14:04 ` Denys Fedoryshchenko
2012-05-19 2:07 ` Tom Herbert
2012-05-19 2:29 ` Denys Fedoryshchenko
2012-05-19 2:40 ` Denys Fedoryshchenko
2012-05-20 17:40 ` Tom Herbert
2012-05-20 18:53 ` Denys Fedoryshchenko
2012-05-20 19:07 ` Eric Dumazet
2012-05-20 19:18 ` Denys Fedoryshchenko
2012-05-21 3:56 ` Eric Dumazet
2012-05-21 8:06 ` Denys Fedoryshchenko
2012-05-21 8:30 ` Eric Dumazet
2012-05-21 8:40 ` Eric Dumazet
2012-05-21 9:22 ` Denys Fedoryshchenko
2012-05-22 17:11 ` Denys Fedoryshchenko
2012-05-22 17:24 ` Eric Dumazet
2012-05-25 6:01 ` Tom Herbert
2012-05-25 6:22 ` Eric Dumazet
2012-05-25 16:59 ` Tom Herbert
2012-05-25 17:18 ` Eric Dumazet
2012-05-29 14:25 ` Hiroaki SHIMODA
2012-05-29 14:54 ` Tom Herbert
2012-05-29 15:11 ` Eric Dumazet
2012-05-29 19:52 ` Denys Fedoryshchenko
2012-05-30 0:06 ` Hiroaki SHIMODA
2012-05-30 8:40 ` Eric Dumazet
2012-05-30 10:43 ` Hiroaki SHIMODA
2012-05-30 11:08 ` Eric Dumazet
2012-05-30 11:20 ` Joe Perches
2012-05-30 11:59 ` Eric Dumazet
2012-05-30 14:09 ` Joe Perches
2012-05-30 14:42 ` Eric Dumazet
2012-05-30 14:50 ` Joe Perches
2012-05-30 11:29 ` Hiroaki SHIMODA
2012-05-30 14:49 ` Eric Dumazet
2012-05-30 15:00 ` dave taht
2012-05-30 22:19 ` Hiroaki SHIMODA
2012-05-30 10:52 ` David Laight
2012-05-30 11:04 ` Eric Dumazet
2012-05-30 11:12 ` Eric Dumazet
2012-06-06 5:10 ` Eric Dumazet
2012-06-06 8:43 ` Hiroaki SHIMODA
2012-06-06 16:26 ` Jesse Brandeburg
2012-06-06 17:05 ` Eric Dumazet
2012-06-06 17:26 ` David Miller
2012-06-06 17:19 ` Hiroaki SHIMODA [this message]
2012-06-06 18:21 ` Tom Herbert
2012-06-06 18:23 ` David Miller
2012-06-06 18:46 ` Stephen Hemminger
2012-05-20 18:13 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607021937.a5638bfd.shimoda.hiroaki@gmail.com \
--to=shimoda.hiroaki@gmail.com \
--cc=davem@davemloft.net \
--cc=denys@visp.net.lb \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eric.dumazet@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).