* Re: [PATCH torvalds/linux.git] Make linux/tcp.h C++ friendly (trivial) [not found] <20111229183002.9B4F4190B09@elbrus2.mtv.corp.google.com> @ 2012-02-03 21:33 ` Jiri Kosina 2012-03-07 0:14 ` Paul Pluzhnikov 0 siblings, 1 reply; 9+ messages in thread From: Jiri Kosina @ 2012-02-03 21:33 UTC (permalink / raw) To: Paul Pluzhnikov; +Cc: netdev On Thu, 29 Dec 2011, Paul Pluzhnikov wrote: > Greetings, > > Using linux/tcp.h from C++ results in: > > cat t.cc > > #include <linux/tcp.h> > int main() { } > > g++ -c t.cc > > In file included from t.cc:1: > /usr/include/linux/tcp.h:72: error: '__u32 __fswab32(__u32)' cannot appear in a constant-expression > /usr/include/linux/tcp.h:72: error: a function call cannot appear in a constant-expression > ... Paul, thanks for the patch. I'd however prefer this to go through netdev, not feeling like this is fully appropriate for trivial tree. Adding netdev to CC and keeping the changelog and patch below for reference. > > Attached trivial patch fixes this problem. > > Tested: > - the t.cc above compiles with g++ and > - the following program generates the same output before/after > the patch: > > #include <linux/tcp.h> > #include <stdio.h> > > int main () > { > #define P(a) printf("%s: %08x\n", #a, (int)a) > P(TCP_FLAG_CWR); > P(TCP_FLAG_ECE); > P(TCP_FLAG_URG); > P(TCP_FLAG_ACK); > P(TCP_FLAG_PSH); > P(TCP_FLAG_RST); > P(TCP_FLAG_SYN); > P(TCP_FLAG_FIN); > P(TCP_RESERVED_BITS); > P(TCP_DATA_OFFSET); > #undef P > return 0; > } > > Signed-off-by: Paul Pluzhnikov <ppluzhnikov@google.com> > > > Thanks, > > P.S. Google has blanket copyright assignment to FSF. > -- > Paul Pluzhnikov > > > diff --git a/include/linux/tcp.h b/include/linux/tcp.h > index 7f59ee9..63334f7 100644 > --- a/include/linux/tcp.h > +++ b/include/linux/tcp.h > @@ -69,16 +69,16 @@ union tcp_word_hdr { > #define tcp_flag_word(tp) ( ((union tcp_word_hdr *)(tp))->words [3]) > > enum { > - TCP_FLAG_CWR = __cpu_to_be32(0x00800000), > - TCP_FLAG_ECE = __cpu_to_be32(0x00400000), > - TCP_FLAG_URG = __cpu_to_be32(0x00200000), > - TCP_FLAG_ACK = __cpu_to_be32(0x00100000), > - TCP_FLAG_PSH = __cpu_to_be32(0x00080000), > - TCP_FLAG_RST = __cpu_to_be32(0x00040000), > - TCP_FLAG_SYN = __cpu_to_be32(0x00020000), > - TCP_FLAG_FIN = __cpu_to_be32(0x00010000), > - TCP_RESERVED_BITS = __cpu_to_be32(0x0F000000), > - TCP_DATA_OFFSET = __cpu_to_be32(0xF0000000) > + TCP_FLAG_CWR = __constant_cpu_to_be32(0x00800000), > + TCP_FLAG_ECE = __constant_cpu_to_be32(0x00400000), > + TCP_FLAG_URG = __constant_cpu_to_be32(0x00200000), > + TCP_FLAG_ACK = __constant_cpu_to_be32(0x00100000), > + TCP_FLAG_PSH = __constant_cpu_to_be32(0x00080000), > + TCP_FLAG_RST = __constant_cpu_to_be32(0x00040000), > + TCP_FLAG_SYN = __constant_cpu_to_be32(0x00020000), > + TCP_FLAG_FIN = __constant_cpu_to_be32(0x00010000), > + TCP_RESERVED_BITS = __constant_cpu_to_be32(0x0F000000), > + TCP_DATA_OFFSET = __constant_cpu_to_be32(0xF0000000) > }; > > /* > -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH torvalds/linux.git] Make linux/tcp.h C++ friendly (trivial) 2012-02-03 21:33 ` [PATCH torvalds/linux.git] Make linux/tcp.h C++ friendly (trivial) Jiri Kosina @ 2012-03-07 0:14 ` Paul Pluzhnikov 2012-06-09 4:14 ` Paul Pluzhnikov 0 siblings, 1 reply; 9+ messages in thread From: Paul Pluzhnikov @ 2012-03-07 0:14 UTC (permalink / raw) To: Jiri Kosina; +Cc: netdev [-- Attachment #1: Type: text/plain, Size: 3167 bytes --] Ping? I am attaching the patch again so it doesn't get mangled by quoting and is easier to apply. Thanks, On Fri, Feb 3, 2012 at 1:33 PM, Jiri Kosina <jkosina@suse.cz> wrote: > On Thu, 29 Dec 2011, Paul Pluzhnikov wrote: > >> Greetings, >> >> Using linux/tcp.h from C++ results in: >> >> cat t.cc >> >> #include <linux/tcp.h> >> int main() { } >> >> g++ -c t.cc >> >> In file included from t.cc:1: >> /usr/include/linux/tcp.h:72: error: '__u32 __fswab32(__u32)' cannot appear in a constant-expression >> /usr/include/linux/tcp.h:72: error: a function call cannot appear in a constant-expression >> ... > > Paul, > > thanks for the patch. I'd however prefer this to go through netdev, not > feeling like this is fully appropriate for trivial tree. > > Adding netdev to CC and keeping the changelog and patch below for > reference. > >> >> Attached trivial patch fixes this problem. >> >> Tested: >> - the t.cc above compiles with g++ and >> - the following program generates the same output before/after >> the patch: >> >> #include <linux/tcp.h> >> #include <stdio.h> >> >> int main () >> { >> #define P(a) printf("%s: %08x\n", #a, (int)a) >> P(TCP_FLAG_CWR); >> P(TCP_FLAG_ECE); >> P(TCP_FLAG_URG); >> P(TCP_FLAG_ACK); >> P(TCP_FLAG_PSH); >> P(TCP_FLAG_RST); >> P(TCP_FLAG_SYN); >> P(TCP_FLAG_FIN); >> P(TCP_RESERVED_BITS); >> P(TCP_DATA_OFFSET); >> #undef P >> return 0; >> } >> >> Signed-off-by: Paul Pluzhnikov <ppluzhnikov@google.com> >> >> >> Thanks, >> >> P.S. Google has blanket copyright assignment to FSF. >> -- >> Paul Pluzhnikov >> >> >> diff --git a/include/linux/tcp.h b/include/linux/tcp.h >> index 7f59ee9..63334f7 100644 >> --- a/include/linux/tcp.h >> +++ b/include/linux/tcp.h >> @@ -69,16 +69,16 @@ union tcp_word_hdr { >> #define tcp_flag_word(tp) ( ((union tcp_word_hdr *)(tp))->words [3]) >> >> enum { >> - TCP_FLAG_CWR = __cpu_to_be32(0x00800000), >> - TCP_FLAG_ECE = __cpu_to_be32(0x00400000), >> - TCP_FLAG_URG = __cpu_to_be32(0x00200000), >> - TCP_FLAG_ACK = __cpu_to_be32(0x00100000), >> - TCP_FLAG_PSH = __cpu_to_be32(0x00080000), >> - TCP_FLAG_RST = __cpu_to_be32(0x00040000), >> - TCP_FLAG_SYN = __cpu_to_be32(0x00020000), >> - TCP_FLAG_FIN = __cpu_to_be32(0x00010000), >> - TCP_RESERVED_BITS = __cpu_to_be32(0x0F000000), >> - TCP_DATA_OFFSET = __cpu_to_be32(0xF0000000) >> + TCP_FLAG_CWR = __constant_cpu_to_be32(0x00800000), >> + TCP_FLAG_ECE = __constant_cpu_to_be32(0x00400000), >> + TCP_FLAG_URG = __constant_cpu_to_be32(0x00200000), >> + TCP_FLAG_ACK = __constant_cpu_to_be32(0x00100000), >> + TCP_FLAG_PSH = __constant_cpu_to_be32(0x00080000), >> + TCP_FLAG_RST = __constant_cpu_to_be32(0x00040000), >> + TCP_FLAG_SYN = __constant_cpu_to_be32(0x00020000), >> + TCP_FLAG_FIN = __constant_cpu_to_be32(0x00010000), >> + TCP_RESERVED_BITS = __constant_cpu_to_be32(0x0F000000), >> + TCP_DATA_OFFSET = __constant_cpu_to_be32(0xF0000000) >> }; >> >> /* >> > > -- > Jiri Kosina > SUSE Labs -- Paul Pluzhnikov [-- Attachment #2: linux-tcp_h-patch-20111229.txt --] [-- Type: text/plain, Size: 1255 bytes --] diff --git a/include/linux/tcp.h b/include/linux/tcp.h index 7f59ee9..63334f7 100644 --- a/include/linux/tcp.h +++ b/include/linux/tcp.h @@ -69,16 +69,16 @@ union tcp_word_hdr { #define tcp_flag_word(tp) ( ((union tcp_word_hdr *)(tp))->words [3]) enum { - TCP_FLAG_CWR = __cpu_to_be32(0x00800000), - TCP_FLAG_ECE = __cpu_to_be32(0x00400000), - TCP_FLAG_URG = __cpu_to_be32(0x00200000), - TCP_FLAG_ACK = __cpu_to_be32(0x00100000), - TCP_FLAG_PSH = __cpu_to_be32(0x00080000), - TCP_FLAG_RST = __cpu_to_be32(0x00040000), - TCP_FLAG_SYN = __cpu_to_be32(0x00020000), - TCP_FLAG_FIN = __cpu_to_be32(0x00010000), - TCP_RESERVED_BITS = __cpu_to_be32(0x0F000000), - TCP_DATA_OFFSET = __cpu_to_be32(0xF0000000) + TCP_FLAG_CWR = __constant_cpu_to_be32(0x00800000), + TCP_FLAG_ECE = __constant_cpu_to_be32(0x00400000), + TCP_FLAG_URG = __constant_cpu_to_be32(0x00200000), + TCP_FLAG_ACK = __constant_cpu_to_be32(0x00100000), + TCP_FLAG_PSH = __constant_cpu_to_be32(0x00080000), + TCP_FLAG_RST = __constant_cpu_to_be32(0x00040000), + TCP_FLAG_SYN = __constant_cpu_to_be32(0x00020000), + TCP_FLAG_FIN = __constant_cpu_to_be32(0x00010000), + TCP_RESERVED_BITS = __constant_cpu_to_be32(0x0F000000), + TCP_DATA_OFFSET = __constant_cpu_to_be32(0xF0000000) }; /* ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH torvalds/linux.git] Make linux/tcp.h C++ friendly (trivial) 2012-03-07 0:14 ` Paul Pluzhnikov @ 2012-06-09 4:14 ` Paul Pluzhnikov 2012-06-09 5:17 ` David Miller 0 siblings, 1 reply; 9+ messages in thread From: Paul Pluzhnikov @ 2012-06-09 4:14 UTC (permalink / raw) To: Jiri Kosina; +Cc: netdev [-- Attachment #1: Type: text/plain, Size: 776 bytes --] On Tue, Mar 6, 2012 at 4:14 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote: > Ping? > > I am attaching the patch again so it doesn't get mangled by quoting > and is easier to apply. Ping? Ping? I thought the patch has been applied, and stopped pinging it. But it appears that it never did get applied :-( Thanks, On Thu, Dec 29, 2011 at 10:30 AM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote: > > Using linux/tcp.h from C++ results in: > > cat t.cc > > #include <linux/tcp.h> > int main() { } > > g++ -c t.cc > > In file included from t.cc:1: > /usr/include/linux/tcp.h:72: error: '__u32 __fswab32(__u32)' cannot appear in a constant-expression > /usr/include/linux/tcp.h:72: error: a function call cannot appear in a constant-expression > ... -- Paul Pluzhnikov [-- Attachment #2: linux-tcp_h-patch-20111229.txt --] [-- Type: text/plain, Size: 1255 bytes --] diff --git a/include/linux/tcp.h b/include/linux/tcp.h index 7f59ee9..63334f7 100644 --- a/include/linux/tcp.h +++ b/include/linux/tcp.h @@ -69,16 +69,16 @@ union tcp_word_hdr { #define tcp_flag_word(tp) ( ((union tcp_word_hdr *)(tp))->words [3]) enum { - TCP_FLAG_CWR = __cpu_to_be32(0x00800000), - TCP_FLAG_ECE = __cpu_to_be32(0x00400000), - TCP_FLAG_URG = __cpu_to_be32(0x00200000), - TCP_FLAG_ACK = __cpu_to_be32(0x00100000), - TCP_FLAG_PSH = __cpu_to_be32(0x00080000), - TCP_FLAG_RST = __cpu_to_be32(0x00040000), - TCP_FLAG_SYN = __cpu_to_be32(0x00020000), - TCP_FLAG_FIN = __cpu_to_be32(0x00010000), - TCP_RESERVED_BITS = __cpu_to_be32(0x0F000000), - TCP_DATA_OFFSET = __cpu_to_be32(0xF0000000) + TCP_FLAG_CWR = __constant_cpu_to_be32(0x00800000), + TCP_FLAG_ECE = __constant_cpu_to_be32(0x00400000), + TCP_FLAG_URG = __constant_cpu_to_be32(0x00200000), + TCP_FLAG_ACK = __constant_cpu_to_be32(0x00100000), + TCP_FLAG_PSH = __constant_cpu_to_be32(0x00080000), + TCP_FLAG_RST = __constant_cpu_to_be32(0x00040000), + TCP_FLAG_SYN = __constant_cpu_to_be32(0x00020000), + TCP_FLAG_FIN = __constant_cpu_to_be32(0x00010000), + TCP_RESERVED_BITS = __constant_cpu_to_be32(0x0F000000), + TCP_DATA_OFFSET = __constant_cpu_to_be32(0xF0000000) }; /* ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH torvalds/linux.git] Make linux/tcp.h C++ friendly (trivial) 2012-06-09 4:14 ` Paul Pluzhnikov @ 2012-06-09 5:17 ` David Miller 2012-06-09 5:45 ` Paul Pluzhnikov 0 siblings, 1 reply; 9+ messages in thread From: David Miller @ 2012-06-09 5:17 UTC (permalink / raw) To: ppluzhnikov; +Cc: jkosina, netdev From: Paul Pluzhnikov <ppluzhnikov@google.com> Date: Fri, 8 Jun 2012 21:14:19 -0700 > I thought the patch has been applied, and stopped pinging it. > But it appears that it never did get applied :-( Your submission is not properly formed, you need to post this as a fresh email with proper commit message and signoffs. Please read Documentation/SubmittingPatches if you want us to seriously consider this change. Thanks. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH torvalds/linux.git] Make linux/tcp.h C++ friendly (trivial) 2012-06-09 5:17 ` David Miller @ 2012-06-09 5:45 ` Paul Pluzhnikov 2012-06-09 5:55 ` David Miller 0 siblings, 1 reply; 9+ messages in thread From: Paul Pluzhnikov @ 2012-06-09 5:45 UTC (permalink / raw) To: David Miller; +Cc: jkosina, netdev [-- Attachment #1: Type: text/plain, Size: 1605 bytes --] On Fri, Jun 8, 2012 at 10:17 PM, David Miller <davem@davemloft.net> wrote: > From: Paul Pluzhnikov <ppluzhnikov@google.com> > Date: Fri, 8 Jun 2012 21:14:19 -0700 > >> I thought the patch has been applied, and stopped pinging it. >> But it appears that it never did get applied :-( > > Your submission is not properly formed, you need to post this as a > fresh email with proper commit message and signoffs. > > Please read Documentation/SubmittingPatches if you want us to > seriously consider this change. Here is the original message I sent to <trivial@kernel.org> on Thu, Dec 29, 2011 at 10:30 AM: ----------------------------------------- Greetings, Using linux/tcp.h from C++ results in: cat t.cc #include <linux/tcp.h> int main() { } g++ -c t.cc In file included from t.cc:1: /usr/include/linux/tcp.h:72: error: '__u32 __fswab32(__u32)' cannot appear in a constant-expression /usr/include/linux/tcp.h:72: error: a function call cannot appear in a constant-expression ... Attached trivial patch fixes this problem. Tested: - the t.cc above compiles with g++ and - the following program generates the same output before/after the patch: #include <linux/tcp.h> #include <stdio.h> int main () { #define P(a) printf("%s: %08x\n", #a, (int)a) P(TCP_FLAG_CWR); P(TCP_FLAG_ECE); P(TCP_FLAG_URG); P(TCP_FLAG_ACK); P(TCP_FLAG_PSH); P(TCP_FLAG_RST); P(TCP_FLAG_SYN); P(TCP_FLAG_FIN); P(TCP_RESERVED_BITS); P(TCP_DATA_OFFSET); #undef P return 0; } Signed-off-by: Paul Pluzhnikov <ppluzhnikov@google.com> Thanks, P.S. Google has blanket copyright assignment to FSF. -- Paul Pluzhnikov [-- Attachment #2: linux-tcp_h-patch-20111229.txt --] [-- Type: text/plain, Size: 1255 bytes --] diff --git a/include/linux/tcp.h b/include/linux/tcp.h index 7f59ee9..63334f7 100644 --- a/include/linux/tcp.h +++ b/include/linux/tcp.h @@ -69,16 +69,16 @@ union tcp_word_hdr { #define tcp_flag_word(tp) ( ((union tcp_word_hdr *)(tp))->words [3]) enum { - TCP_FLAG_CWR = __cpu_to_be32(0x00800000), - TCP_FLAG_ECE = __cpu_to_be32(0x00400000), - TCP_FLAG_URG = __cpu_to_be32(0x00200000), - TCP_FLAG_ACK = __cpu_to_be32(0x00100000), - TCP_FLAG_PSH = __cpu_to_be32(0x00080000), - TCP_FLAG_RST = __cpu_to_be32(0x00040000), - TCP_FLAG_SYN = __cpu_to_be32(0x00020000), - TCP_FLAG_FIN = __cpu_to_be32(0x00010000), - TCP_RESERVED_BITS = __cpu_to_be32(0x0F000000), - TCP_DATA_OFFSET = __cpu_to_be32(0xF0000000) + TCP_FLAG_CWR = __constant_cpu_to_be32(0x00800000), + TCP_FLAG_ECE = __constant_cpu_to_be32(0x00400000), + TCP_FLAG_URG = __constant_cpu_to_be32(0x00200000), + TCP_FLAG_ACK = __constant_cpu_to_be32(0x00100000), + TCP_FLAG_PSH = __constant_cpu_to_be32(0x00080000), + TCP_FLAG_RST = __constant_cpu_to_be32(0x00040000), + TCP_FLAG_SYN = __constant_cpu_to_be32(0x00020000), + TCP_FLAG_FIN = __constant_cpu_to_be32(0x00010000), + TCP_RESERVED_BITS = __constant_cpu_to_be32(0x0F000000), + TCP_DATA_OFFSET = __constant_cpu_to_be32(0xF0000000) }; /* ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH torvalds/linux.git] Make linux/tcp.h C++ friendly (trivial) 2012-06-09 5:45 ` Paul Pluzhnikov @ 2012-06-09 5:55 ` David Miller 0 siblings, 0 replies; 9+ messages in thread From: David Miller @ 2012-06-09 5:55 UTC (permalink / raw) To: ppluzhnikov; +Cc: jkosina, netdev From: Paul Pluzhnikov <ppluzhnikov@google.com> Date: Fri, 8 Jun 2012 22:45:20 -0700 > On Fri, Jun 8, 2012 at 10:17 PM, David Miller <davem@davemloft.net> wrote: >> From: Paul Pluzhnikov <ppluzhnikov@google.com> >> Date: Fri, 8 Jun 2012 21:14:19 -0700 >> >>> I thought the patch has been applied, and stopped pinging it. >>> But it appears that it never did get applied :-( >> >> Your submission is not properly formed, you need to post this as a >> fresh email with proper commit message and signoffs. >> >> Please read Documentation/SubmittingPatches if you want us to >> seriously consider this change. > > Here is the original message I sent to <trivial@kernel.org> on > Thu, Dec 29, 2011 at 10:30 AM: Please make a new, proper submission. I didn't ask you to reference your original submission did I? Thank you. ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH torvalds/linux.git] Make linux/tcp.h C++ friendly (trivial)
@ 2012-06-09 14:53 Paul Pluzhnikov
2012-06-10 4:26 ` David Miller
0 siblings, 1 reply; 9+ messages in thread
From: Paul Pluzhnikov @ 2012-06-09 14:53 UTC (permalink / raw)
To: netdev; +Cc: ppluzhnikov, Jiri Kosina, David Miller
From: Paul Pluzhnikov <ppluzhnikov@google.com>
I originally sent this patch to <trivial@kernel.org>, but Jiri Kosina did
not feel that this is fully appropriate for the trivial tree.
Using linux/tcp.h from C++ results in:
cat t.cc
#include <linux/tcp.h>
int main() { }
g++ -c t.cc
In file included from t.cc:1:
/usr/include/linux/tcp.h:72: error: '__u32 __fswab32(__u32)' cannot appear in a constant-expression
/usr/include/linux/tcp.h:72: error: a function call cannot appear in a constant-expression
...
Attached trivial patch fixes this problem.
Tested:
- the t.cc above compiles with g++ and
- the following program generates the same output before/after
the patch:
#include <linux/tcp.h>
#include <stdio.h>
int main ()
{
#define P(a) printf("%s: %08x\n", #a, (int)a)
P(TCP_FLAG_CWR);
P(TCP_FLAG_ECE);
P(TCP_FLAG_URG);
P(TCP_FLAG_ACK);
P(TCP_FLAG_PSH);
P(TCP_FLAG_RST);
P(TCP_FLAG_SYN);
P(TCP_FLAG_FIN);
P(TCP_RESERVED_BITS);
P(TCP_DATA_OFFSET);
#undef P
return 0;
}
Thanks,
P.S. Google has blanket copyright assignment to FSF.
Signed-off-by: Paul Pluzhnikov <ppluzhnikov@google.com>
---
diff --git a/include/linux/tcp.h b/include/linux/tcp.h
index 4c5b632..5f359db 100644
--- a/include/linux/tcp.h
+++ b/include/linux/tcp.h
@@ -69,16 +69,16 @@ union tcp_word_hdr {
#define tcp_flag_word(tp) ( ((union tcp_word_hdr *)(tp))->words [3])
enum {
- TCP_FLAG_CWR = __cpu_to_be32(0x00800000),
- TCP_FLAG_ECE = __cpu_to_be32(0x00400000),
- TCP_FLAG_URG = __cpu_to_be32(0x00200000),
- TCP_FLAG_ACK = __cpu_to_be32(0x00100000),
- TCP_FLAG_PSH = __cpu_to_be32(0x00080000),
- TCP_FLAG_RST = __cpu_to_be32(0x00040000),
- TCP_FLAG_SYN = __cpu_to_be32(0x00020000),
- TCP_FLAG_FIN = __cpu_to_be32(0x00010000),
- TCP_RESERVED_BITS = __cpu_to_be32(0x0F000000),
- TCP_DATA_OFFSET = __cpu_to_be32(0xF0000000)
+ TCP_FLAG_CWR = __constant_cpu_to_be32(0x00800000),
+ TCP_FLAG_ECE = __constant_cpu_to_be32(0x00400000),
+ TCP_FLAG_URG = __constant_cpu_to_be32(0x00200000),
+ TCP_FLAG_ACK = __constant_cpu_to_be32(0x00100000),
+ TCP_FLAG_PSH = __constant_cpu_to_be32(0x00080000),
+ TCP_FLAG_RST = __constant_cpu_to_be32(0x00040000),
+ TCP_FLAG_SYN = __constant_cpu_to_be32(0x00020000),
+ TCP_FLAG_FIN = __constant_cpu_to_be32(0x00010000),
+ TCP_RESERVED_BITS = __constant_cpu_to_be32(0x0F000000),
+ TCP_DATA_OFFSET = __constant_cpu_to_be32(0xF0000000)
};
/*
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH torvalds/linux.git] Make linux/tcp.h C++ friendly (trivial) 2012-06-09 14:53 Paul Pluzhnikov @ 2012-06-10 4:26 ` David Miller 2012-06-10 4:39 ` Paul Pluzhnikov 0 siblings, 1 reply; 9+ messages in thread From: David Miller @ 2012-06-10 4:26 UTC (permalink / raw) To: ppluzhnikov; +Cc: netdev, jkosina From: ppluzhnikov@google.com (Paul Pluzhnikov) Date: Sat, 9 Jun 2012 07:53:03 -0700 (PDT) > P.S. Google has blanket copyright assignment to FSF. FSF assignments have no applicability with the Linux kernel. This really eliminates the reason why I asked you to make a fresh submission of the patch. I asked you to do this so that I could just apply your patch using "git am --signoff" but I can't, now I have to edit out all of this irrelevant text you added to the email. I have to edit out this "P.S." thing, because it's irrelevant. I have to edit out all of the trite things like "Thanks," too. Oh well, II'll edit it up and apply your patch this time. But for future submissions put only essential things into the email content because that ends up in the commit message. If you want to say "extra" stuff say it after the "---" because things said after "---" don't make it into the commit log message. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH torvalds/linux.git] Make linux/tcp.h C++ friendly (trivial) 2012-06-10 4:26 ` David Miller @ 2012-06-10 4:39 ` Paul Pluzhnikov 0 siblings, 0 replies; 9+ messages in thread From: Paul Pluzhnikov @ 2012-06-10 4:39 UTC (permalink / raw) To: David Miller; +Cc: netdev, jkosina On Sat, Jun 9, 2012 at 9:26 PM, David Miller <davem@davemloft.net> wrote: > Oh well, II'll edit it up and apply your patch this time. Thanks. Sorry about the extra work. > But for future submissions put only essential things into the email Will do. Thanks again. -- Paul Pluzhnikov ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-06-10 4:39 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20111229183002.9B4F4190B09@elbrus2.mtv.corp.google.com>
2012-02-03 21:33 ` [PATCH torvalds/linux.git] Make linux/tcp.h C++ friendly (trivial) Jiri Kosina
2012-03-07 0:14 ` Paul Pluzhnikov
2012-06-09 4:14 ` Paul Pluzhnikov
2012-06-09 5:17 ` David Miller
2012-06-09 5:45 ` Paul Pluzhnikov
2012-06-09 5:55 ` David Miller
2012-06-09 14:53 Paul Pluzhnikov
2012-06-10 4:26 ` David Miller
2012-06-10 4:39 ` Paul Pluzhnikov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).