From: Dan Carpenter <dan.carpenter@oracle.com>
To: yuvalmin@broadcom.com
Cc: netdev@vger.kernel.org
Subject: re: bnx2x: Added EEE support
Date: Fri, 8 Jun 2012 16:09:21 +0300 [thread overview]
Message-ID: <20120608130921.GA19268@elgon.mountain> (raw)
Hello Yuval Mintz,
The patch c8c60d88c59c: "bnx2x: Added EEE support" from Jun 6, 2012,
leads to the following warning:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c:10121
bnx2x_848x3_config_init()
error: buffer overflow 'params->req_duplex' 2 <= 4
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
10032 actual_phy_selection = bnx2x_phy_selection(params);
10033
10034 switch (actual_phy_selection) {
10035 case PORT_HW_CFG_PHY_SELECTION_HARDWARE_DEFAULT:
10036 /* Do nothing. Essentially this is like the priority copper */
10037 break;
10038 case PORT_HW_CFG_PHY_SELECTION_FIRST_PHY_PRIORITY:
10039 val |= MDIO_CTL_REG_84823_MEDIA_PRIORITY_COPPER;
10040 break;
10041 case PORT_HW_CFG_PHY_SELECTION_SECOND_PHY_PRIORITY:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
We assume "actual_phy_selection" can be 4 here.
10042 val |= MDIO_CTL_REG_84823_MEDIA_PRIORITY_FIBER;
10043 break;
[snip]
10121 if ((params->req_duplex[actual_phy_selection] == DUPLEX_FULL) &&
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This array only has 2 elements so 4 is beyond the end.
10122 (params->eee_mode & EEE_MODE_ADV_LPI) &&
10123 (bnx2x_eee_calc_timer(params) ||
10124 !(params->eee_mode & EEE_MODE_ENABLE_LPI)))
10125 rc = bnx2x_8483x_enable_eee(phy, params, vars);
10126 else
regards,
dan carpenter
next reply other threads:[~2012-06-08 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 13:09 Dan Carpenter [this message]
2012-06-10 7:47 ` bnx2x: Added EEE support Yuval Mintz
2012-10-22 12:06 ` Dan Carpenter
2012-10-22 12:15 ` Yuval Mintz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120608130921.GA19268@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=yuvalmin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox