From: David Miller <davem@davemloft.net>
To: roland@kernel.org
Cc: netdev@vger.kernel.org, roland@purestorage.com
Subject: Re: [PATCH] net: Reorder initialization in ip_route_output to fix gcc warning
Date: Sun, 10 Jun 2012 23:44:11 -0700 (PDT) [thread overview]
Message-ID: <20120610.234411.850948486629299757.davem@davemloft.net> (raw)
In-Reply-To: <1339394724-28296-1-git-send-email-roland@kernel.org>
From: Roland Dreier <roland@kernel.org>
Date: Sun, 10 Jun 2012 23:05:24 -0700
> From: Roland Dreier <roland@purestorage.com>
>
> If I build with W=1, for every file that includes <net/route.h>, I get the warning
>
> include/net/route.h: In function 'ip_route_output':
> include/net/route.h:135:3: warning: initialized field overwritten [-Woverride-init]
> include/net/route.h:135:3: warning: (near initialization for 'fl4') [-Woverride-init]
>
> (This is with "gcc (Debian 4.6.3-1) 4.6.3")
>
> A fix seems pretty trivial: move the initialization of .flowi4_tos
> earlier. As far as I can tell, this has no effect on code generation.
>
> Signed-off-by: Roland Dreier <roland@purestorage.com>
I can't figure out what it is actually warning about, can you?
next prev parent reply other threads:[~2012-06-11 6:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 6:05 [PATCH] net: Reorder initialization in ip_route_output to fix gcc warning Roland Dreier
2012-06-11 6:44 ` David Miller [this message]
2012-06-11 7:00 ` Roland Dreier
2012-06-11 7:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120610.234411.850948486629299757.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roland@kernel.org \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).