Re: [PATCH] net: Reorder initialization in ip_route_output to fix gcc warning

[David Miller <davem@davemloft.net>]

From: Roland Dreier <roland@kernel.org>
Date: Mon, 11 Jun 2012 00:00:51 -0700

>> I can't figure out what it is actually warning about, can you?
> 
> I think gcc thinks it already initialized the __fl_common struct
> once when it hits the .flowi4_oif initializer (which expands to
> __fl_common.flowic_oif), and then having the .daddr / .saddr
> initializers makes it thinks its done with that structure.
> 
> So it thinks it's initializing __fl_common.flowic_tos to 0, and
> then the .flowi4_tos initializer comes along as a surprise.
> 
> Hmm, looks like http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52880
> which is fixed after gcc 4.7.0.  I think it's probably worth working
> around this gcc issue, since this makes W=1 way noisier in
> my build.

I suspected it was a compiler bug :-)

Anyways, agreed, applied.