From: David Miller <davem@davemloft.net>
To: shaw500@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RESEND] net: socket: Fixed some style issues and condensed list of fixes.
Date: Mon, 11 Jun 2012 16:45:07 -0700 (PDT) [thread overview]
Message-ID: <20120611.164507.1289803990715626884.davem@davemloft.net> (raw)
In-Reply-To: <1339444359-16248-1-git-send-email-shaw500@gmail.com>
From: Matthew Shaw <shaw500@gmail.com>
Date: Mon, 11 Jun 2012 20:52:39 +0100
> From: Matthew Shaw <mjshaw@athena.(none)>
>
> There was an instance of brackets in an if statement that was not
> required, and a number of lines that exceeded 80 chars. The fixes
> list has also been condensed to simply list the people that should
> be credited with various fixes in net/socket.c throughout its
> developement.
>
> Signed-off-by: Matthew Shaw <shaw500@gmail.com>
I don't see any value in this patch, and the comment fixups don't use
the recommended coding style in the networking, you would need to get
rid of all of that extraneous whitespace between "/* ", "* ", and the
actual test.
But again I really see no value to this change, so I won't be applying
a patch like this, in any form.
prev parent reply other threads:[~2012-06-11 23:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 19:52 [PATCH][RESEND] net: socket: Fixed some style issues and condensed list of fixes Matthew Shaw
2012-06-11 23:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611.164507.1289803990715626884.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shaw500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).